Skip Menu |
 

This queue is for tickets about the Biblio-COUNTER CPAN distribution.

Report information
The Basics
Id: 51993
Status: new
Priority: 0/
Queue: Biblio-COUNTER

People
Owner: Nobody in particular
Requestors: holbrook [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.11
Fixed in: (no value)

Attachments


Subject: Accessors in Biblio::COUNTER::Report incorrect?
Download (untitled) / with headers
text/plain 191b
I think the accessors for fields in Biblio::COUNTER::Report are incorrect. They refer to fields in the report which are actually in the report header. The attached patch fixed these for me.
Subject: Bilbio-COUNTER-Report.patch
191,198c191,198 < sub name { @_ > 1 ? $_[0]->{'header'}->{NAME() } = $_[1] : $_[0]->{'header'}->{NAME() } } < sub code { @_ > 1 ? $_[0]->{'header'}->{CODE() } = $_[1] : $_[0]->{'header'}->{CODE() } } < sub release { @_ > 1 ? $_[0]->{'header'}->{RELEASE() } = $_[1] : $_[0]->{'header'}->{RELEASE() } } < sub description { @_ > 1 ? $_[0]->{'header'}->{DESCRIPTION()} = $_[1] : $_[0]->{'header'}->{DESCRIPTION()} } < sub date_run { @_ > 1 ? $_[0]->{'header'}->{DATE_RUN() } = $_[1] : $_[0]->{'header'}->{DATE_RUN() } } < sub criteria { @_ > 1 ? $_[0]->{'header'}->{CRITERIA() } = $_[1] : $_[0]->{'header'}->{CRITERIA() } } < sub publisher { @_ > 1 ? $_[0]->{'header'}->{PUBLISHER() } = $_[1] : $_[0]->{'header'}->{PUBLISHER() } } < sub platform { @_ > 1 ? $_[0]->{'header'}->{PLATFORM() } = $_[1] : $_[0]->{'header'}->{PLATFORM() } } --- > sub name { @_ > 1 ? $_[0]->{'report'}->{NAME() } = $_[1] : $_[0]->{'report'}->{NAME() } } > sub code { @_ > 1 ? $_[0]->{'report'}->{CODE() } = $_[1] : $_[0]->{'report'}->{CODE() } } > sub release { @_ > 1 ? $_[0]->{'report'}->{RELEASE() } = $_[1] : $_[0]->{'report'}->{RELEASE() } } > sub description { @_ > 1 ? $_[0]->{'report'}->{DESCRIPTION()} = $_[1] : $_[0]->{'report'}->{DESCRIPTION()} } > sub date_run { @_ > 1 ? $_[0]->{'report'}->{DATE_RUN() } = $_[1] : $_[0]->{'report'}->{DATE_RUN() } } > sub criteria { @_ > 1 ? $_[0]->{'report'}->{CRITERIA() } = $_[1] : $_[0]->{'report'}->{CRITERIA() } } > sub publisher { @_ > 1 ? $_[0]->{'report'}->{PUBLISHER() } = $_[1] : $_[0]->{'report'}->{PUBLISHER() } } > sub platform { @_ > 1 ? $_[0]->{'report'}->{PLATFORM() } = $_[1] : $_[0]->{'report'}->{PLATFORM() } }


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.