Skip Menu |

This queue is for tickets about the DBD-Pg CPAN distribution.

Report information
The Basics
Id: 51856
Status: resolved
Priority: 0/
Queue: DBD-Pg

Owner: greg [...]
Requestors: FWIE [...]

Bug Information
Severity: (no value)
Broken in: 2.15.1
Fixed in: 2.16.0

Subject: [Patch] POD nits
The attached patch fixes some POD, which renders wrong, at least at
Subject: pod.patch
Download pod.patch
text/x-diff 3.4k
diff --git a/ b/ index 1753b87..3e34c0f 100644 --- a/ +++ b/ @@ -1841,7 +1841,7 @@ host, like this: {AutoCommit => 0, RaiseError => 1}); The attribute hash can also contain a key named C<dbd_verbose>, which -simply calls C<$dbh->trace('DBD')> after the handle is created. This attribute +simply calls C<< $dbh->trace('DBD') >> after the handle is created. This attribute is not recommended, as it is clearer to simply explicitly call C<trace> explicitly in your script. @@ -1888,7 +1888,7 @@ indicates no error (CONNECTION_OK), while any other number indicates a failed co only other number commonly seen is 1 (CONNECTION_BAD). See the libpq documentation for the complete list of return codes. -In all other non-connect methods C<$h->err> returns the C<PQresultStatus> of the current +In all other non-connect methods C<< $h->err >> returns the C<PQresultStatus> of the current handle. This is a number used by libpq and is one of: 0 Empty query string @@ -1915,8 +1915,8 @@ Returns a five-character "SQLSTATE" code. Success is indicated by a C<00000> cod gets mapped to an empty string by DBI. A code of C<S8006> indicates a connection failure, usually because the connection to the Postgres server has been lost. -While this method can be called as either C<$sth->state> or C<$dbh->state>, it -is usually clearer to always use C<$dbh->state>. +While this method can be called as either C<< $sth->state >> or C<< $dbh->state >>, it +is usually clearer to always use C<< $dbh->state >>. The list of codes used by PostgreSQL can be found at: L<> @@ -1992,7 +1992,7 @@ Outputs all SQL statements. Note that the output provided will not necessarily be in a form suitable to passing directly to Postgres, as server-side prepared statements are used extensively by DBD::Pg. For maximum portability of output (but with a potential performance -hit), use with C<$dbh->{pg_server_prepare} = 0> +hit), use with C<< $dbh->{pg_server_prepare} = 0 >>. =item DBD @@ -2580,7 +2580,7 @@ constraint, and which uses a sequence as a default value. If more than one colum meets these conditions, the primary key will be used. This involves some looking up of things in the system table, so DBD::Pg will cache the sequence name for subsequent calls. If you need to disable this caching for some reason, -(such as the sequence name changing), you can control it by adding C<pg_cache => 0> +(such as the sequence name changing), you can control it by adding C<< pg_cache => 0 >> to the final (hashref) argument for last_insert_id. Please keep in mind that this method is far from foolproof, so make your diff --git a/t/lib/App/ b/t/lib/App/ index e3df872..3112597 100644 --- a/t/lib/App/ +++ b/t/lib/App/ @@ -1184,7 +1184,7 @@ handling arguments to set up the event handlers, so that when we call C<confirm()> or C<unknown()> the event will be handled as the client expects. If we needed our subclass constructor to take its own parameter argumente, the -approach is to specify the same C<key => $arg> syntax as is used by +approach is to specify the same C<< key => $arg >> syntax as is used by App::Info's C<new()> method. Say we wanted to allow clients of our App::Info subclass to pass in a list of alternate executable locations for us to search. Such an argument would most make sense as an array reference. So we specify
Thank you! Applied in svn (r13584), will be in the next release (which will be 2.15.2 or 2.16.0)

This service is sponsored and maintained by Best Practical Solutions and runs on infrastructure.

Please report any issues with to