Skip Menu |
 

This queue is for tickets about the Test-WWW-Selenium CPAN distribution.

Report information
The Basics
Id: 51738
Status: resolved
Priority: 0/
Queue: Test-WWW-Selenium

People
Owner: Nobody in particular
Requestors: frequency [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.20
Fixed in: (no value)



Subject: Broken POD (+PATCH)
Download (untitled) / with headers
text/plain 767b
Hi: While updating this package for Debian, I came across a messy WWW::Selenium POD (I noticed you also removed the POD test for this, which was probably a bad idea...) Anyway, I have discovered that it's just a one-line fix due to a =back that is offset by a space; you have: =back rather than =back So the POD isn't seeing that as a command, and as such screws up the whole POD. The patch (see attached) will be applied to the Debian package; feel free to integrate it into yours upstream. I've also corrected some inconsistencies (some methods have * and some do not) while in there. However, I notice also that the comments say this information is generated from a javascript file, so I'm not sure if this is really a bug in the generator. Cheers, Jonathan
Subject: fix-pod.patch
Download fix-pod.patch
text/x-diff 1.6k
Description: fix POD errors Author: Jonathan Yu <jawnsy@cpan.org> Origin: vendor Forwarded: no --- a/lib/WWW/Selenium.pm +++ b/lib/WWW/Selenium.pm @@ -3213,7 +3213,7 @@ "default" - The default library. Currently the default library is "ajaxslt" . - =back +=back If libraryName isn't one of these three, then no change will be made. @@ -3421,7 +3421,7 @@ } -=item * $sel-E<gt>is_location($expected_location) +=item $sel-E<gt>is_location($expected_location) Verify the location of the current page ends with the expected location. If an URL querystring is provided, this is checked as well. @@ -3445,7 +3445,7 @@ return $loc =~ /\Q$expected_location\E$/; } -=item * $sel-E<gt>get_checked($locator) +=item $sel-E<gt>get_checked($locator) Gets whether a toggle-button (checkbox/radio) is checked. Fails if the specified element doesn't exist or isn't a toggle-button. @@ -3466,7 +3466,7 @@ return $self->get_string("isChecked", @_) ? 'true' : 'false'; } -=item * $sel-E<gt>is_selected($locator, $option_locator) +=item $sel-E<gt>is_selected($locator, $option_locator) Verifies that the selected option of a drop-down satisfies the optionSpecifier. @@ -3496,7 +3496,7 @@ return grep { $pattern eq $_ } @selected; } -=item * $sel-E<gt>get_selected_options($locator) +=item $sel-E<gt>get_selected_options($locator) Gets all option labels for selected options in the specified select or multi-select element. @@ -3517,7 +3517,7 @@ return $self->get_string_array("getSelectedLabels", @_); } -=item * $sel-E<gt>get_absolute_location() +=item $sel-E<gt>get_absolute_location() Gets the absolute URL of the current page.
Subject: Re: [rt.cpan.org #51738] Broken POD (+PATCH)
Date: Thu, 19 Nov 2009 10:02:05 -0800
To: bug-Test-WWW-Selenium [...] rt.cpan.org
From: Luke Closs <lukecloss [...] gmail.com>
Download (untitled) / with headers
text/plain 1.3k
Thanks, I'll look into this. FWIW, the code all lives here: http://github.com/lukec/cpan-selenium-rc-perl Cheers, Luke On Thu, Nov 19, 2009 at 9:59 AM, Jonathan Yu via RT <bug-Test-WWW-Selenium@rt.cpan.org> wrote: Show quoted text
> Thu Nov 19 12:59:55 2009: Request 51738 was acted upon. > Transaction: Ticket created by FREQUENCY >       Queue: Test-WWW-Selenium >     Subject: Broken POD (+PATCH) >   Broken in: 1.20 >    Severity: Normal >       Owner: Nobody >  Requestors: frequency@cpan.org >      Status: new >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=51738 > > > > Hi: > > While updating this package for Debian, I came across a messy > WWW::Selenium POD (I noticed you also removed the POD test for this, > which was probably a bad idea...) > > Anyway, I have discovered that it's just a one-line fix due to a =back > that is offset by a space; you have: >  =back > rather than > =back > > So the POD isn't seeing that as a command, and as such screws up the > whole POD. > > The patch (see attached) will be applied to the Debian package; feel > free to integrate it into yours upstream. I've also corrected some > inconsistencies (some methods have * and some do not) while in there. > However, I notice also that the comments say this information is > generated from a javascript file, so I'm not sure if this is really a > bug in the generator. > > Cheers, > > Jonathan >
Download (untitled) / with headers
text/plain 19.9k

Message body is not shown because it is too large.

Subject: Re: [rt.cpan.org #51738] Broken POD (+PATCH)
Date: Mon, 7 Feb 2011 10:08:22 -0800
To: bug-Test-WWW-Selenium [...] rt.cpan.org
From: Luke Closs <lukecloss [...] gmail.com>
Download (untitled) / with headers
text/plain 20.9k

Message body is not shown because it is too large.

Download (untitled) / with headers
text/plain 943b
I've fixed all the POD errors in WWW/Selenium.pm in the just released 1.24. On Thu Nov 19 12:59:55 2009, FREQUENCY wrote: Show quoted text
> Hi: > > While updating this package for Debian, I came across a messy > WWW::Selenium POD (I noticed you also removed the POD test for this, > which was probably a bad idea...) > > Anyway, I have discovered that it's just a one-line fix due to a =back > that is offset by a space; you have: > =back > rather than > =back > > So the POD isn't seeing that as a command, and as such screws up the > whole POD. > > The patch (see attached) will be applied to the Debian package; feel > free to integrate it into yours upstream. I've also corrected some > inconsistencies (some methods have * and some do not) while in there. > However, I notice also that the comments say this information is > generated from a javascript file, so I'm not sure if this is really a > bug in the generator. > > Cheers, > > Jonathan


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.