Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the PPI CPAN distribution.

Report information
The Basics
Id: 51181
Status: resolved
Priority: 0/
Queue: PPI

People
Owner: Nobody in particular
Requestors: wyant [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 1.206
Fixed in: (no value)



Subject: Expose regexp-related PPI::Token::_QuoteEngine::Full goodies to the world
Download (untitled) / with headers
text/plain 976b
There are some goodies in the internals of PPI::Token::_QuoteEngine::Full that would be of considerable interest to (at least) people interested in taking regular expressions apart. What I propose is adding some private routines to PPI::Token::_QuoteEngine::Full to return the content of a given string section, the modifiers hash, and an array of the delimiters used. The proposal also adds public methods to PPI::Token::Regexp and PPI::Token::QuoteLike::Regexp to wrap these private methods in something civilized. The proposed private methods on the quote engine are _section_content($inx), _modifiers(), and _delimiters(). The proposed public methods that wrap these are get_match_string(), get_substitute_string(), get_modifiers(), and get_delimiters(). I have no particularly strong desire to advocate for the proposed names - you may not like the "get_" convention, in which case please go with what works. The proposed enhancement is committed as svn revision 9985.
Subject: Re: [rt.cpan.org #51181] Expose regexp-related PPI::Token::_QuoteEngine::Full goodies to the world
Date: Sat, 7 Nov 2009 13:07:11 +1100
To: bug-PPI [...] rt.cpan.org
From: Adam Kennedy <adamkennedybackup [...] gmail.com>
Download (untitled) / with headers
text/plain 1.6k
Sounds like a pretty good idea, I've been watching your regex stuff with interest. Please note I'm going to be horrendously busy until the first week of December, if you can ping me then to remind me to review it, I'll take a look at it then. Adam K 2009/11/7 Tom Wyant via RT <bug-PPI@rt.cpan.org>: Show quoted text
> Fri Nov 06 19:37:38 2009: Request 51181 was acted upon. > Transaction: Ticket created by WYANT >       Queue: PPI >     Subject: Expose regexp-related PPI::Token::_QuoteEngine::Full goodies to >  the world >   Broken in: 1.206 >    Severity: Wishlist >       Owner: Nobody >  Requestors: wyant@cpan.org >      Status: new >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=51181 > > > > There are some goodies in the internals of > PPI::Token::_QuoteEngine::Full that would be of considerable interest to > (at least) people interested in taking regular expressions apart. > > What I propose is adding some private routines to > PPI::Token::_QuoteEngine::Full to return the content of a given string > section, the modifiers hash, and an array of the delimiters used. The > proposal also adds public methods to PPI::Token::Regexp and > PPI::Token::QuoteLike::Regexp to wrap these private methods in something > civilized. > > The proposed private methods on the quote engine are > _section_content($inx), _modifiers(), and _delimiters(). The proposed > public methods that wrap these are get_match_string(), > get_substitute_string(), get_modifiers(), and get_delimiters(). I have > no particularly strong desire to advocate for the proposed names - you > may not like the "get_" convention, in which case please go with what works. > > The proposed enhancement is committed as svn revision 9985. >
Download (untitled) / with headers
text/plain 480b
On Fri Nov 06 21:07:26 2009, adam@ali.as wrote: Show quoted text
> Sounds like a pretty good idea, I've been watching your regex stuff > with interest.
Now, THERE'S a comment that can be taken more than one way! ;-) Show quoted text
> > Please note I'm going to be horrendously busy until the first week of > December, if you can ping me then to remind me to review it, I'll take > a look at it then.
No sweat. We could all get so much done if the real world would just go away and find someone else to bother.
1.208 looks to me like what the doctor ordered. Thank you very much.
Closing this them. :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.