Skip Menu |
 

This queue is for tickets about the POE CPAN distribution.

Report information
The Basics
Id: 51171
Status: resolved
Priority: 0/
Queue: POE

People
Owner: Nobody in particular
Requestors: dolmen [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.280
Fixed in: (no value)



Subject: POE::Wheel::Run->kill return value portability
Download (untitled) / with headers
text/plain 454b
The return value of POE::Wheel::Run->kill() should be portable: same kind of value either Win32 or *n*x. The current code return the return value of CORE::kill() on Unix and Win32::Process::KillProcess on Win32, but those return values have not the same meaning. See TerminateProcess, the Win32 API function used internally by KillProcess() http://msdn.microsoft.com/en-us/library/ms686714%28VS.85%29.aspx -- Olivier Mengué - http://o.mengue.free.fr/
Subject: [FIX] POE::Wheel::Run->kill return value portability
Download (untitled) / with headers
text/plain 470b
Le Ven. Nov. 06 11:25:06 2009, DOLMEN a écrit : Show quoted text
> The return value of POE::Wheel::Run->kill() should be portable: same > kind of value either Win32 or *n*x.
The return value of CORE::kill() is the count of signaled process. So it is either 0 or 1. So the fix is to return the same errors on Win32: Win32::Process::KillProcess( $self->[MSWIN32_GROUP_PID], 293 ) ? 1 : 0; Also the return value should be documented. -- Olivier Mengué - http://o.mengue.free.fr/
Thank you for pointing this out. I've committed your fix as revision 2766.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.