Skip Menu |
 

This queue is for tickets about the PAR-Packer CPAN distribution.

Report information
The Basics
Id: 50747
Status: resolved
Priority: 0/
Queue: PAR-Packer

People
Owner: Nobody in particular
Requestors: plate [...] patterner.de
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.992_04
Fixed in: (no value)



Download (untitled) / with headers
text/plain 221b
In function 'open', inlined from 'my_mkfile' at static.c:34: /usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments
Subject: static.c.patch
Download static.c.patch
text/x-diff 456b
--- static.c.orig 2009-07-19 15:15:35.000000000 +0200 +++ static.c 2009-10-22 13:24:20.000000000 +0200 @@ -31,7 +31,7 @@ if ( (unsigned long)PL_statbuf.st_size == size ) return -2; } - i = open(my_file, O_CREAT | O_WRONLY | OPEN_O_BINARY); + i = open(my_file, O_CREAT | O_WRONLY | OPEN_O_BINARY, 0644); if (i == -1) { fprintf(stderr, "%s: creation of %s failed - aborting with %i.\n", argv0, my_file, errno);
Subject: Re: [rt.cpan.org #50747]
Date: Fri, 13 Nov 2009 09:48:42 +0100
To: bug-PAR-Packer [...] rt.cpan.org
From: Steffen Mueller <nj88udd02 [...] sneakemail.com>
Download (untitled) / with headers
text/plain 1016b
Hi, Joerg Plate via RT wrote: Show quoted text
> Thu Oct 22 07:26:04 2009: Request 50747 was acted upon. > Transaction: Ticket created by PATTERNER > Queue: PAR-Packer > Subject: (No subject given) > Broken in: 0.992_04 > Severity: (no value) > Owner: Nobody > Requestors: plate@patterner.de > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=50747 > > > > In function 'open', > inlined from 'my_mkfile' at static.c:34: > /usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode' > declared with attribute error: open with O_CREAT in second argument > needs 3 arguments
there is now a fix for this from Roderich in the trunk. Roderich's change (which goes back to Marcela Maslanova, if I'm not mistaken) uses 0777 for the permissions. It seems safer to use 0644 here as suggested by Jörg. I'll make a final dev release with 0777 and we can potentially change this before the next stable release. I want to push that out ASAP, though. Cheers, Steffen
Finally: use open(*file_p, O_CREAT | O_WRONLY | OPEN_O_BINARY, 0755); Cheers, Roderich
Fixed in PAR::Packer 1.010 (actually 1.006 - forgot to close this bug)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.