Skip Menu |
 

This queue is for tickets about the Perl-Dist-Strawberry CPAN distribution.

Report information
The Basics
Id: 50294
Status: resolved
Priority: 0/
Queue: Perl-Dist-Strawberry

People
Owner: Nobody in particular
Requestors: kmx [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Warnings in .../perl/lib/CORE/perl.h (when using -Wall)
Download (untitled) / with headers
text/plain 1.3k
Hi, during my research with Image::Magick I have came across the following issue concerning C:/strawberry/perl/lib/CORE/perl.h The problem occurs when module tries to '#include "perl.h"' (all XS do that) and sets '-Wall' in its CCFLAGS as for example Image::Magick - then you will experience the following warnings: ########## ... In file included from C:/strawberry/perl/lib/CORE/perl.h:38, from Magick.xs:61: C:/strawberry/perl/lib/CORE/config.h:39:20: warning: "/*" within comment C:/strawberry/perl/lib/CORE/config.h:45:21: warning: "/*" within comment + many many similar ... ########## The reason is that in config.h there are blocks like this: /* HAS_FORK: * This symbol, if defined, indicates that the fork routine is * available. */ /*#define HAS_FORK /**/ And as you can see the line with "#define HAS_FORK" obviously has some extra '/*' causing the warnings. I am afraid that config.h comes from Perl core and I have no idea why they use this style of comments. The thing I do not understand is why haven't I seen something like this earlier - it is probably very rare to use "CCFLAGS => '-Wall'" in Makefile.pl. I can of course post an RT to Perl::Magick proposing removal of -Wall from their Makefile.pl but a systematic solution would IMHO be to fix config.h in strawberry perl. Anyway the priority is very low. -- kmx
Download (untitled) / with headers
text/plain 1.6k
On Wed Oct 07 10:29:53 2009, KMX wrote: Show quoted text
> Hi, > > during my research with Image::Magick I have came across the following > issue concerning C:/strawberry/perl/lib/CORE/perl.h > > The problem occurs when module tries to '#include "perl.h"' (all XS do > that) and sets '-Wall' in its CCFLAGS as for example Image::Magick - > then you will experience the following warnings: > > ########## > ... > > In file included from C:/strawberry/perl/lib/CORE/perl.h:38, > from Magick.xs:61: > C:/strawberry/perl/lib/CORE/config.h:39:20: warning: "/*" within comment > C:/strawberry/perl/lib/CORE/config.h:45:21: warning: "/*" within comment > + many many similar > > ... > ########## > > The reason is that in config.h there are blocks like this: > > /* HAS_FORK: > * This symbol, if defined, indicates that the fork routine is > * available. > */ > /*#define HAS_FORK /**/ > > And as you can see the line with "#define HAS_FORK" obviously has some > extra '/*' causing the warnings. > > I am afraid that config.h comes from Perl core and I have no idea why > they use this style of comments. > > The thing I do not understand is why haven't I seen something like this > earlier - it is probably very rare to use "CCFLAGS => '-Wall'" in > Makefile.pl. > > I can of course post an RT to Perl::Magick proposing removal of -Wall > from their Makefile.pl but a systematic solution would IMHO be to fix > config.h in strawberry perl. > > Anyway the priority is very low. > > -- > kmx
I think that this isn't a Strawberry-specific problem (I'll check in a FreeBSD machine within the next few days and report back).
Reported to rt.perl.org as:

http://rt.perl.org/rt3/Ticket/Display.html?id=71852

--
kmx
Download (untitled) / with headers
text/plain 110b
In this case, we're stalled on p5p (and it's not as if I'm going to patch the 5.10.x series) so marking it so.
This is resolved in 5.12.x builds (and I'm not going to patch 5.10.x/5.8.x builds)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.