Skip Menu |
 

This queue is for tickets about the POE-Component-IRC CPAN distribution.

Report information
The Basics
Id: 49922
Status: resolved
Priority: 0/
Queue: POE-Component-IRC

People
Owner: Nobody in particular
Requestors: yorhel [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
poco-irc-plugin-nickserv-nickchangereturn.patch



Subject: [patch] NickServID Plugin: fix warning on nick change
Download (untitled) / with headers
text/plain 324b
POE::Component::IRC::Plugin::NickServID::S_nick() does not always return a valid value, emiting the following warning whenever someone in a joined channel changes his/her nick: S_nick call on plugin 'NickServID' did not return a valid EAT constant Attached patch (against 6.12-11-g533eb52) is what I presume to be a fix.
Subject: poco-irc-plugin-nickserv-nickchangereturn.patch
diff --git a/lib/POE/Component/IRC/Plugin/NickServID.pm b/lib/POE/Component/IRC/Plugin/NickServID.pm index 742397c..bd3a2a8 100644 --- a/lib/POE/Component/IRC/Plugin/NickServID.pm +++ b/lib/POE/Component/IRC/Plugin/NickServID.pm @@ -47,8 +47,8 @@ sub S_nick { my $new_nick = u_irc( ${ $_[1] }, $mapping ); if ( $new_nick eq u_irc($self->{nick}, $mapping) ) { $irc->yield(nickserv => "IDENTIFY $self->{Password}"); - return PCI_EAT_NONE; } + return PCI_EAT_NONE; } 1;
Thanks for that. It'll be fixed in the next release.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.