Skip Menu |
 

This queue is for tickets about the AnyEvent-Kanye CPAN distribution.

Report information
The Basics
Id: 49864
Status: resolved
Priority: 0/
Queue: AnyEvent-Kanye

People
Owner: Nobody in particular
Requestors: CHOCOLATE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.01
Fixed in: (no value)



Subject: Non-canonical wording
The wording is off in several places. Patch attached. chocolateboy
Subject: AnyEvent-Kanye-0.01.patch
diff -ruwb AnyEvent-Kanye-0.01/lib/AnyEvent/Kanye.pm AnyEvent-Kanye-0.01-patched/lib/AnyEvent/Kanye.pm --- AnyEvent-Kanye-0.01/lib/AnyEvent/Kanye.pm 2009-09-20 20:58:07.000000000 +0100 +++ AnyEvent-Kanye-0.01-patched/lib/AnyEvent/Kanye.pm 2009-09-21 00:39:56.000000000 +0100 @@ -4,6 +4,7 @@ use warnings; use AnyEvent (); +use Lingua::EN::Inflect qw(PL); BEGIN { our @ISA = "AnyEvent::CondVar" } @@ -16,11 +17,12 @@ sub send { my ( $self, $thing ) = @_; + my $name = ref($thing) || 'value'; $self->SUPER::send( - "This value is pretty good, and I'm going to let " . - " you finish, but Beyonce had one of the best " . - (ref($thing) || "value") . " of all times!" + "This $name is pretty good, and I'mma let " . + "you finish, but Beyoncé had one of the best " . + PL($name) . " of all time!" ); } diff -ruwb AnyEvent-Kanye-0.01/Makefile.PL AnyEvent-Kanye-0.01-patched/Makefile.PL --- AnyEvent-Kanye-0.01/Makefile.PL 2009-09-20 20:57:27.000000000 +0100 +++ AnyEvent-Kanye-0.01-patched/Makefile.PL 2009-09-21 00:28:36.000000000 +0100 @@ -12,6 +12,7 @@ PL_FILES => { }, PREREQ_PM => { 'AnyEvent' => 0, + 'Lingua::EN::Inflect' => 0, 'Test::More' => 0, 'Test::use::ok' => 0, }, diff -ruwb AnyEvent-Kanye-0.01/t/basic.t AnyEvent-Kanye-0.01-patched/t/basic.t --- AnyEvent-Kanye-0.01/t/basic.t 2009-09-20 20:56:10.000000000 +0100 +++ AnyEvent-Kanye-0.01-patched/t/basic.t 2009-09-21 00:41:21.000000000 +0100 @@ -13,5 +13,4 @@ $cv->send("hello"); -like( $cv->recv, qr/Beyonce/, "interrupted" ); - +like( $cv->recv, qr/Beyoncé/, "interrupted" );
thanks, applied (sorry for not including Changes in the MANIFEST... you'll get credit in 0.03 ;-)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.