Skip Menu |
 

This queue is for tickets about the Apache-Session-Wrapper CPAN distribution.

Report information
The Basics
Id: 49561
Status: resolved
Priority: 0/
Queue: Apache-Session-Wrapper

People
Owner: yves [...] cpan.org
Requestors: demerphq [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.33_01



Subject: [PATCH] Fix user defined options handling and fix default of optional options
Date: Wed, 9 Sep 2009 16:55:45 +0200
To: bug-apache-session-wrapper [...] rt.cpan.org
From: demerphq <demerphq [...] gmail.com>
Download (untitled) / with headers
text/plain 2.3k
I was trying to use Apache::Session::Wrapper via Apache::Session::Flex via MasonX::Request::WithApacheSession with customized configuration via config file, and couldnt figure out how to make things work with custom defined options until I made the following changes. While i was debugging the one issue I noticed that the default optional options was incorrect leading to ARRAY(0xdeadbeef) style keys in internal hashes. Cheers, commit cf3b9051d3dd4e52e034436290e78191b19669bf Author: Yves Orton <demerphq@gemini.(none)> Date: Thu Aug 20 23:04:57 2009 +0200 user config options should default to SCALAR diff --git a/lib/Apache/Session/Wrapper.pm b/lib/Apache/Session/Wrapper.pm index 97595ac..1bdd4ed 100644 --- a/lib/Apache/Session/Wrapper.pm +++ b/lib/Apache/Session/Wrapper.pm @@ -311,7 +311,10 @@ sub _SetValidParams { { for my $p ( map { @$_ } map { @$_ } values %$hash ) { - $extra{$p} = { optional => 1 }; + $extra{$p} = { + optional => 1, + type => SCALAR + }; } } commit 8eda80d6f5c129f3b0f5aa892e6bf8c95f0f4859 Author: Yves Orton <demerphq@gemini.(none)> Date: Thu Aug 20 23:04:02 2009 +0200 default should be an empty array, not an array of empty arrays diff --git a/lib/Apache/Session/Wrapper.pm b/lib/Apache/Session/Wrapper.pm index 66a37a2..97595ac 100644 --- a/lib/Apache/Session/Wrapper.pm +++ b/lib/Apache/Session/Wrapper.pm @@ -350,7 +350,7 @@ sub RegisterClass { my $class = shift; my %p = validate( @_, { name => { type => SCALAR }, required => { type => SCALAR | ARRAYREF, default => [ [ ] ] }, - optional => { type => SCALAR | ARRAYREF, default => [ [ ] ] }, + optional => { type => SCALAR | ARRAYREF, default => [ ] }, }, ); @@ -378,7 +378,7 @@ sub RegisterFlexClass { }, name => { type => SCALAR }, required => { type => SCALAR | ARRAYREF, default => [ [ ] ] }, - optional => { type => SCALAR | ARRAYREF, default => [ [ ] ] }, + optional => { type => SCALAR | ARRAYREF, default => [ ] }, }, ); -- perl -Mre=debug -e "/just|another|perl|hacker/"
Download (untitled) / with headers
text/plain 631b
On Wed Sep 09 10:56:17 2009, demerphq@gmail.com wrote: Show quoted text
> I was trying to use Apache::Session::Wrapper via Apache::Session::Flex > via MasonX::Request::WithApacheSession with customized configuration > via config file, and couldnt figure out how to make things work with > custom defined options until I made the following changes. While i was > debugging the one issue I noticed that the default optional options > was incorrect leading to ARRAY(0xdeadbeef) style keys in internal > hashes.
I don't support you want to take this module over? I don't use it for anything these days and I really have no interest in maintaining it.
Subject: Re: [rt.cpan.org #49561] [PATCH] Fix user defined options handling and fix default of optional options
Date: Fri, 18 Sep 2009 12:52:13 +0200
To: bug-Apache-Session-Wrapper [...] rt.cpan.org
From: demerphq <demerphq [...] gmail.com>
2009/9/12 DROLSKY via RT <bug-Apache-Session-Wrapper@rt.cpan.org>: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=49561 > > > On Wed Sep 09 10:56:17 2009, demerphq@gmail.com wrote:
>> I was trying to use Apache::Session::Wrapper via Apache::Session::Flex >> via MasonX::Request::WithApacheSession with customized configuration >> via config file, and couldnt figure out how to make things work with >> custom defined options until I made the following changes. While i was >> debugging the one issue I noticed that the default optional options >> was incorrect leading to ARRAY(0xdeadbeef) style keys in internal >> hashes.
> > I don't support you want to take this module over? I don't use it for > anything these days and I really have no interest in maintaining it.
I guess so. Better than letting it be orphaned. Although Id prefer co-maint, not a full transfer, id like to think there was a second set of eyes at least watching what happens. Of course i guess i can just add my own co-maintainers. cheers, Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"
Subject: Re: [rt.cpan.org #49561] [PATCH] Fix user defined options handling and fix default of optional options
Date: Sun, 20 Sep 2009 13:58:22 -0500 (CDT)
To: demerphq via RT <bug-Apache-Session-Wrapper [...] rt.cpan.org>
From: Dave Rolsky <autarch [...] urth.org>
Download (untitled) / with headers
text/plain 657b
On Fri, 18 Sep 2009, demerphq via RT wrote: Show quoted text
> I guess so. Better than letting it be orphaned. Although Id prefer > co-maint, not a full transfer, id like to think there was a second set > of eyes at least watching what happens. Of course i guess i can just > add my own co-maintainers.
I can make you primary and still keep co-maint. That way you can make others co-maint as well. What's you CPAN id? -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/
Subject: Re: [rt.cpan.org #49561] [PATCH] Fix user defined options handling and fix default of optional options
Date: Mon, 21 Sep 2009 09:37:55 +0200
To: bug-Apache-Session-Wrapper [...] rt.cpan.org
From: demerphq <demerphq [...] gmail.com>
Download (untitled) / with headers
text/plain 626b
2009/9/20 autarch@urth.org via RT <bug-Apache-Session-Wrapper@rt.cpan.org>: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=49561 > > > On Fri, 18 Sep 2009, demerphq via RT wrote: >
>> I guess so. Better than letting it be orphaned. Although Id prefer >> co-maint, not a full transfer, id like to think there was a second set >> of eyes at least watching what happens. Of course i guess i can just >> add my own co-maintainers.
> > I can make you primary and still keep co-maint. That way you can make > others co-maint as well. What's you CPAN id?
YVES Cheers, yves -- perl -Mre=debug -e "/just|another|perl|hacker/"
Subject: Re: [rt.cpan.org #49561] [PATCH] Fix user defined options handling and fix default of optional options
Date: Mon, 21 Sep 2009 08:30:36 -0500 (CDT)
To: demerphq via RT <bug-Apache-Session-Wrapper [...] rt.cpan.org>
From: Dave Rolsky <autarch [...] urth.org>
Download (untitled) / with headers
text/plain 1009b
On Mon, 21 Sep 2009, demerphq via RT wrote: Show quoted text
> Queue: Apache-Session-Wrapper > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=49561 > > > 2009/9/20 autarch@urth.org via RT <bug-Apache-Session-Wrapper@rt.cpan.org>:
>> <URL: https://rt.cpan.org/Ticket/Display.html?id=49561 > >> >> On Fri, 18 Sep 2009, demerphq via RT wrote: >>
>>> I guess so. Better than letting it be orphaned. Although Id prefer >>> co-maint, not a full transfer, id like to think there was a second set >>> of eyes at least watching what happens. Of course i guess i can just >>> add my own co-maintainers.
>> >> I can make you primary and still keep co-maint. That way you can make >> others co-maint as well. What's you CPAN id?
> > YVES
Alright, you have primary now. -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.