Skip Menu |
 

This queue is for tickets about the Test-WWW-Selenium CPAN distribution.

Report information
The Basics
Id: 49345
Status: resolved
Priority: 0/
Queue: Test-WWW-Selenium

People
Owner: Nobody in particular
Requestors: frequency [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: Deprecation Warnings
Download (untitled) / with headers
text/plain 752b
Hi: While upgrading the Test::WWW::Selenium package in Debian, I came across some warnings during build: get_absolute_location() is deprecated, use get_location() get_absolute_location() is deprecated, use get_location() These are evident during CPAN Testers reports too, though you might not have noticed since the tests still PASS. You might want to consider using Test::NoWarnings in the future to turn these warnings into FAILures, so you notice them and can fix them for future releases. Here is an example CPAN Testers report: http://www.nntp.perl.org/group/perl.cpan.testers/2009/09/msg5195068.html -- By the way, congratulations on your 100% CPAN Testers PASS rate so far. Thanks for writing and maintaining this module. Cheers, Jonathan
Subject: Re: [rt.cpan.org #49345] Deprecation Warnings
Date: Tue, 1 Sep 2009 21:38:55 -0700
To: bug-Test-WWW-Selenium [...] rt.cpan.org
From: Luke Closs <lukecloss [...] gmail.com>
Download (untitled) / with headers
text/plain 1.4k
I actually have those deprication warnings as part of the code for downstream users. Perhaps the tests could be improved to test for that warning. Thank you for maintaining the debian package! Cheers, Luke On Tue, Sep 1, 2009 at 1:35 PM, Jonathan Yu via RT<bug-Test-WWW-Selenium@rt.cpan.org> wrote: Show quoted text
> Tue Sep 01 16:35:27 2009: Request 49345 was acted upon. > Transaction: Ticket created by FREQUENCY >       Queue: Test-WWW-Selenium >     Subject: Deprecation Warnings >   Broken in: (no value) >    Severity: Important >       Owner: Nobody >  Requestors: frequency@cpan.org >      Status: new >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=49345 > > > > Hi: > > While upgrading the Test::WWW::Selenium package in Debian, I came across > some warnings during build: > > get_absolute_location() is deprecated, use get_location() > get_absolute_location() is deprecated, use get_location() > > These are evident during CPAN Testers reports too, though you might not > have noticed since the tests still PASS. You might want to consider > using Test::NoWarnings in the future to turn these warnings into > FAILures, so you notice them and can fix them for future releases. > > Here is an example CPAN Testers report: > http://www.nntp.perl.org/group/perl.cpan.testers/2009/09/msg5195068.html > -- By the way, congratulations on your 100% CPAN Testers PASS rate so far. > > Thanks for writing and maintaining this module. > > Cheers, > > Jonathan >
From: frequency [...] cpan.org
Download (untitled) / with headers
text/plain 2.1k
Hi Luke! Thanks for the quick reply. On Wed Sep 02 00:39:13 2009, lukecloss@gmail.com wrote: Show quoted text
> I actually have those deprication warnings as part of the code for > downstream users.
Oh, I didn't know that. Should we upload the package as-is (with the warnings and this explanation that they are OK), or should we wait on a new upload? Show quoted text
> > Perhaps the tests could be improved to test for that warning.
Yeah, I believe Test::Warn will test that warnings happen, and will also mute the warnings from displaying (by using a $SIG{__WARN__} hook or something to that effect). This way you get the robustness of testing for it while not worrying users that install the package ;-) Thanks! Show quoted text
> > Thank you for maintaining the debian package!
You're welcome. It seems to be relatively popular with our users: http://qa.debian.org/popcon.php?package=libtest-www-selenium-perl Show quoted text
> > Cheers, > Luke > > On Tue, Sep 1, 2009 at 1:35 PM, Jonathan Yu via > RT<bug-Test-WWW-Selenium@rt.cpan.org> wrote:
> > Tue Sep 01 16:35:27 2009: Request 49345 was acted upon. > > Transaction: Ticket created by FREQUENCY > >       Queue: Test-WWW-Selenium > >     Subject: Deprecation Warnings > >   Broken in: (no value) > >    Severity: Important > >       Owner: Nobody > >  Requestors: frequency@cpan.org > >      Status: new > >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=49345 > > > > > > > Hi: > > > > While upgrading the Test::WWW::Selenium package in Debian, I came across > > some warnings during build: > > > > get_absolute_location() is deprecated, use get_location() > > get_absolute_location() is deprecated, use get_location() > > > > These are evident during CPAN Testers reports too, though you might not > > have noticed since the tests still PASS. You might want to consider > > using Test::NoWarnings in the future to turn these warnings into > > FAILures, so you notice them and can fix them for future releases. > > > > Here is an example CPAN Testers report: > > http://www.nntp.perl.org/group/perl.cpan.testers/2009/09/msg5195068.html > > -- By the way, congratulations on your 100% CPAN Testers PASS rate
so far. Show quoted text
> > > > Thanks for writing and maintaining this module. > > > > Cheers, > > > > Jonathan > >
Download (untitled) / with headers
text/plain 2.5k
I've fixed the test, but I don't really want to push out a new release just for this fix. I'm gonna mark this as fixed in 1.19 whenever that goes out. Cheers, Luke On Wed Sep 02 13:17:59 2009, FREQUENCY wrote: Show quoted text
> Hi Luke! > > Thanks for the quick reply. > > On Wed Sep 02 00:39:13 2009, lukecloss@gmail.com wrote:
> > I actually have those deprication warnings as part of the code for > > downstream users.
> Oh, I didn't know that. Should we upload the package as-is (with the > warnings and this explanation that they are OK), or should we wait on a > new upload?
> > > > Perhaps the tests could be improved to test for that warning.
> Yeah, I believe Test::Warn will test that warnings happen, and will also > mute the warnings from displaying (by using a $SIG{__WARN__} hook or > something to that effect). This way you get the robustness of testing > for it while not worrying users that install the package ;-) > > Thanks!
> > > > Thank you for maintaining the debian package!
> > You're welcome. It seems to be relatively popular with our users: > http://qa.debian.org/popcon.php?package=libtest-www-selenium-perl
> > > > Cheers, > > Luke > > > > On Tue, Sep 1, 2009 at 1:35 PM, Jonathan Yu via > > RT<bug-Test-WWW-Selenium@rt.cpan.org> wrote:
> > > Tue Sep 01 16:35:27 2009: Request 49345 was acted upon. > > > Transaction: Ticket created by FREQUENCY > > >       Queue: Test-WWW-Selenium > > >     Subject: Deprecation Warnings > > >   Broken in: (no value) > > >    Severity: Important > > >       Owner: Nobody > > >  Requestors: frequency@cpan.org > > >      Status: new > > >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=49345 > > > > > > > > > > Hi: > > > > > > While upgrading the Test::WWW::Selenium package in Debian, I came
across Show quoted text
> > > some warnings during build: > > > > > > get_absolute_location() is deprecated, use get_location() > > > get_absolute_location() is deprecated, use get_location() > > > > > > These are evident during CPAN Testers reports too, though you
might not Show quoted text
> > > have noticed since the tests still PASS. You might want to consider > > > using Test::NoWarnings in the future to turn these warnings into > > > FAILures, so you notice them and can fix them for future releases. > > > > > > Here is an example CPAN Testers report: > > >
http://www.nntp.perl.org/group/perl.cpan.testers/2009/09/msg5195068.html Show quoted text
> > > -- By the way, congratulations on your 100% CPAN Testers PASS rate
> so far.
> > > > > > Thanks for writing and maintaining this module. > > > > > > Cheers, > > > > > > Jonathan > > >
> >


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.