Skip Menu |
 

This queue is for tickets about the Imager CPAN distribution.

Report information
The Basics
Id: 49275
Status: resolved
Priority: 0/
Queue: Imager

People
Owner: TONYC [...] cpan.org
Requestors: kmx [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.67
Fixed in: (no value)



Subject: Win32 compatibility patch
Download (untitled) / with headers
text/plain 1.1k
Hi, I would like to propose the following patch to Makefile.PL: @@ -424,7 +424,9 @@ push(@incs, split /;/, $ENV{INCLUDE}) if exists $ENV{INCLUDE}; } if ($Config{incpath}) { - push @incs, grep -d, split /\Q$Config{path_sep}/, $Config{incpath}; + foreach my $i (grep -d, split /\Q$Config{path_sep}/, $Config{incpath}) { + push @incs, [ $i, "$i/freetype2" ]; + } } push @incs, grep -d, qw(/sw/include It concerns freetype support and it just adds additional "-I" include dirs based on $Config{incpath}. - if $Config{incpath} contains e.g. "c:\strawberry\c\include" - we add into @incs c:\strawberry\c\include as well as c:\strawberry\c\include\freetype2 This makes compilation on Win32/strawberry easier - currently you do not put c:\straberry\c\include\freetype2 into @incs. Give me please at least a short feedback if you find this patch sane. We are about to add graphics bin libs (libpng, libgif, libtiff, libfreetype) into October release of Win32/strawberry perl and I just need to know whether I can expect this patch applied till october or if I should find some workaround for this issue. -- kmx
Download (untitled) / with headers
text/plain 405b
Show quoted text
> We are about to add graphics bin libs (libpng, libgif, libtiff, > libfreetype) into October release of Win32/strawberry perl and I just > need to know whether I can expect this patch applied till october or if > I should find some workaround for this issue.
He's doing the graphics library additions at my request - we can work around it if need be, but it would be better if you could do this soon.
Download (untitled) / with headers
text/plain 239b
Unfortunately it's the modifications to freetype2 which you make which breaks Makefile.PL's existing probe. Rather than working around your workaround for SDL, I've fixed Makefile.PL to use freetype-config when present as a .bat on win32.
Download (untitled) / with headers
text/plain 370b
On Mon Aug 31 08:00:51 2009, TONYC wrote: Show quoted text
> Rather than working around your workaround for SDL, I've fixed > Makefile.PL to use freetype-config when present as a .bat on win32.
This looks like it's in 0.67_01, correct? If so, I'll try this tomorrow (I'm getting too tired tonight.) [0.67 worked fine with everything but freetype when I tried it tonight.] --Curtis
Subject: Re: [rt.cpan.org #49275] Win32 compatibility patch
Date: Mon, 07 Sep 2009 08:18:45 +0200
To: bug-Imager [...] rt.cpan.org
From: kmx <kmx [...] volny.cz>
Show quoted text
> This looks like it's in 0.67_01, correct?
Yes 0.67_01 works fine. -- kmx
Thanks for the report. Fixed in Imager 0.68.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.