Skip Menu |
 

This queue is for tickets about the MooseX-POE CPAN distribution.

Report information
The Basics
Id: 48854
Status: new
Priority: 0/
Queue: MooseX-POE

People
Owner: Nobody in particular
Requestors: rdb [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



Subject: Improved clarity in ex/serial_watcher.pl
Download (untitled) / with headers
text/plain 436b
The example serves to introduce MX::POE to the new user. In it, attributes and their builders are shown, and then LATER, the events referenced in the builders are set. The attached patch re-orders the event declarations to immediately follow the place where they're first mentioned (e.g. InputHandler => "got_console" is followed by event got_console). This follows the principal of least surprise, and groups relevant info together.
Subject: reordered.patch
Download reordered.patch
text/x-diff 1.5k
--- serial_orig/serial_watcher.pl 2009-06-26 08:35:13.000000000 -0700 +++ serial_watcher.pl 2009-08-18 19:57:34.000000000 -0700 @@ -65,6 +65,22 @@ ); } +event got_port => sub { # wheel gave us some data: + my ( $self, $data ) = @_; # [OBJECT, ARG0]; + $self->console->put($data); +}; + +event got_error => sub { + my ( $self, @args) = @_; # [OBJECT, ARG0...$#_ ]; + + $self->console->put("$args[0] error $args[1]: $args[2]"); + $self->console->put("Bye!"); + + $self->clear_device; + $self->clear_console; + +}; + has console => ( is => 'ro', isa => 'POE::Wheel::ReadLine', @@ -78,19 +94,6 @@ POE::Wheel::ReadLine->new( InputEvent => "got_console" ); } -sub START { - my $self = shift; - - # make sure our wheels are started up *in the session* - $self->device; - $self->console; -} - -event got_port => sub { # wheel gave us some data: - my ( $self, $data ) = @_; # [OBJECT, ARG0]; - $self->console->put($data); -}; - event got_console => sub { my ( $self, $input ) = @_; # [OBJECT, ARG0]; if ( defined $input ) { @@ -111,16 +114,13 @@ $self->clear_console; }; -event got_error => sub { - my ( $self, @args) = @_; # [OBJECT, ARG0...$#_ ]; - - $self->console->put("$args[0] error $args[1]: $args[2]"); - $self->console->put("Bye!"); - - $self->clear_device; - $self->clear_console; +sub START { + my $self = shift; -}; + # make sure our wheels are started up *in the session* + $self->device; + $self->console; +} no MooseX::POE;


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.