Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Locale-Maketext CPAN distribution.

Report information
The Basics
Id: 48808
Status: resolved
Priority: 0/
Queue: Locale-Maketext

People
Owner: TODDR [...] cpan.org
Requestors: dmuey [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.15_01



Subject: [1.14 target - item #5] I18N::LangTags use() fixups
Download (untitled) / with headers
text/plain 517b
Locale::Maketext does this: use I18N::LangTags 0.30 (); presumably because that is when I18N::LangTags::Detect was added and it uses I18N::LangTags::Detect I propose this change which wouldd seem a little saner since 0.30 is many years old (i.e. most people will have it) and is much more explicit about what we actually need: 2 small changes: #1) change: use I18N::LangTags 0.30 (); to use I18N::LangTags (); use I18N::LangTags::Detect (); now we know #2) remove require I18N::LangTags::Detect;
Download (untitled) / with headers
text/plain 159b
To make it easier to review and implement I've put all changes into a single small patch. This is a complete patch w/ Changelog and version 1.13_86 -> 1.13_87
Download rt48808.patch
text/x-diff 1.4k
diff -ruN Locale-Maketext-1.13_86/ChangeLog Locale-Maketext-1.13_87/ChangeLog --- Locale-Maketext-1.13_86/ChangeLog 2009-07-30 14:10:43.000000000 -0500 +++ Locale-Maketext-1.13_87/ChangeLog 2009-08-18 09:57:48.000000000 -0500 @@ -1,5 +1,10 @@ Revision history for Perl suite Locale::Maketext +2009-08-18 Adriano Ferreira + * Development release 1.13_87 + + I18N::LangTags use() fixups (thanks Dan Muey) + 2009-08-04 Adriano Ferreira * Development release 1.13_86 diff -ruN Locale-Maketext-1.13_86/lib/Locale/Maketext.pm Locale-Maketext-1.13_87/lib/Locale/Maketext.pm --- Locale-Maketext-1.13_86/lib/Locale/Maketext.pm 2009-07-30 15:04:16.000000000 -0500 +++ Locale-Maketext-1.13_87/lib/Locale/Maketext.pm 2009-08-18 09:58:25.000000000 -0500 @@ -3,14 +3,15 @@ use vars qw( @ISA $VERSION $MATCH_SUPERS $USING_LANGUAGE_TAGS $USE_LITERALS $MATCH_SUPERS_TIGHTLY); use Carp (); -use I18N::LangTags 0.30 (); +use I18N::LangTags (); +use I18N::LangTags::Detect (); #-------------------------------------------------------------------------- BEGIN { unless(defined &DEBUG) { *DEBUG = sub () {0} } } # define the constant 'DEBUG' at compile-time -$VERSION = '1.13_86'; +$VERSION = '1.13_87'; $VERSION = eval $VERSION; @ISA = (); @@ -380,7 +381,6 @@ ########################################################################### sub _ambient_langprefs { - require I18N::LangTags::Detect; return I18N::LangTags::Detect::detect(); }
Download (untitled) / with headers
text/plain 159b
To make it easier to review and implement I've put all changes into a single small patch. This is a complete patch w/ Changelog and version 1.13_86 -> 1.13_87
Download rt48808.patch
text/x-diff 1.4k
diff -ruN Locale-Maketext-1.13_86/ChangeLog Locale-Maketext-1.13_87/ChangeLog --- Locale-Maketext-1.13_86/ChangeLog 2009-07-30 14:10:43.000000000 -0500 +++ Locale-Maketext-1.13_87/ChangeLog 2009-08-18 09:57:48.000000000 -0500 @@ -1,5 +1,10 @@ Revision history for Perl suite Locale::Maketext +2009-08-18 Adriano Ferreira + * Development release 1.13_87 + + I18N::LangTags use() fixups (thanks Dan Muey) + 2009-08-04 Adriano Ferreira * Development release 1.13_86 diff -ruN Locale-Maketext-1.13_86/lib/Locale/Maketext.pm Locale-Maketext-1.13_87/lib/Locale/Maketext.pm --- Locale-Maketext-1.13_86/lib/Locale/Maketext.pm 2009-07-30 15:04:16.000000000 -0500 +++ Locale-Maketext-1.13_87/lib/Locale/Maketext.pm 2009-08-18 09:58:25.000000000 -0500 @@ -3,14 +3,15 @@ use vars qw( @ISA $VERSION $MATCH_SUPERS $USING_LANGUAGE_TAGS $USE_LITERALS $MATCH_SUPERS_TIGHTLY); use Carp (); -use I18N::LangTags 0.30 (); +use I18N::LangTags (); +use I18N::LangTags::Detect (); #-------------------------------------------------------------------------- BEGIN { unless(defined &DEBUG) { *DEBUG = sub () {0} } } # define the constant 'DEBUG' at compile-time -$VERSION = '1.13_86'; +$VERSION = '1.13_87'; $VERSION = eval $VERSION; @ISA = (); @@ -380,7 +381,6 @@ ########################################################################### sub _ambient_langprefs { - require I18N::LangTags::Detect; return I18N::LangTags::Detect::detect(); }
Download (untitled) / with headers
text/plain 263b
On Tue Aug 18 11:00:56 2009, DMUEY wrote: Show quoted text
> To make it easier to review and implement I've put all changes into a > single small patch. > > This is a complete patch w/ Changelog and version 1.13_86 -> > 1.13_87
A ready-to-upload-via-pause tarball of said patch
Download Locale-Maketext-1.13_87.tar.gz
application/x-gzip 48.4k

Message body not shown because it is not plain text.

From: toddr [...] null.net
Download (untitled) / with headers
text/plain 242b
forked perl blead on github - http://github.com/toddr/perl/tree/toddr/maketext-locale will be submitting to P5P post 5.12.0 freeze per advice from jesse Commit: http://github.com/toddr/perl/commit/81e01086442355736cb1435d8568 66069c5cf2ee
Download (untitled) / with headers
text/plain 840b
Accepted by p5p - commit ed897e29a200fd3c758cb7ab8c0d953347a98056 Author: Todd Rinaldo <toddr@cpan.org> Date: Tue Sep 28 12:19:58 2010 -0500 perl RT# 76668 - This patch resolves CPAN RT #48808. This change: 1. loads I18N::LangTags::Detect in BEGIN rather than whenever _ambient_langprefs is called 2. Removes the version number requirement for I18N::LangTags. Detect didn't come around until 0.31 so a dep on 0.30 is unnecessary. This will assure any load issues with I18N::LangTags::Detect happen at BEGIN, not randomly somewhere in the program. This does increase the dependency on I18N::LangTags from 0.30 to 0.31, but the release dates are as follows, so I don't think it's a big deal: 0.30 - 2004-03-30 Sean M. Burke sburke@cpan.org 0.31 - 2004-06-17 Sean M. Burke sburke@cpan.org
1.15_02 is the RC for 1.16. No issues so far. closing ticket.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.