Skip Menu |
 

This queue is for tickets about the DBD-SQLite CPAN distribution.

Report information
The Basics
Id: 48048
Status: resolved
Priority: 0/
Queue: DBD-SQLite

People
Owner: Nobody in particular
Requestors: DAMI [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: (no value)
Fixed in: (no value)



Subject: improper "require utf8" in tests
Download (untitled) / with headers
text/plain 497b
Tests "33_non_latin_path.t" and "rt_25924_user_defined_func_unicode.t" invoke the "utf8" pragma. However, according to the doc, this pragma is supposed to be used only if the source code is in utf8, which is not the case here. So it is quite likely that accented characters in those tests are misinterpreted, and that the tests nevertheless pass by mere accident. Note : the tests invoke "utf8::upgrade(...)", but this function is always available, doesn't need any "require utf8" or "use utf8".
Download (untitled) / with headers
text/plain 614b
Removed "(use|require) utf8" from the trunk. Thanks. On Tue Jul 21 19:11:25 2009, DAMI wrote: Show quoted text
> Tests "33_non_latin_path.t" and "rt_25924_user_defined_func_unicode.t" > invoke the "utf8" pragma. However, according to the doc, this pragma
is Show quoted text
> supposed to be used only if the source code is in utf8, which is not
the Show quoted text
> case here. So it is quite likely that accented characters in those
tests Show quoted text
> are misinterpreted, and that the tests nevertheless pass by mere
accident. Show quoted text
> > Note : the tests invoke "utf8::upgrade(...)", but this function is > always available, doesn't need any "require utf8" or "use utf8".
Download (untitled) / with headers
text/plain 754b
DBD::SQLite 1.38_01 with this fix is released. Thanks. On Sat Sep 01 22:11:54 2012, ISHIGAKI wrote: Show quoted text
> Removed "(use|require) utf8" from the trunk. Thanks. > > On Tue Jul 21 19:11:25 2009, DAMI wrote:
> > Tests "33_non_latin_path.t" and
"rt_25924_user_defined_func_unicode.t" Show quoted text
> > invoke the "utf8" pragma. However, according to the doc, this
pragma Show quoted text
> is
> > supposed to be used only if the source code is in utf8, which is
not Show quoted text
> the
> > case here. So it is quite likely that accented characters in those
> tests
> > are misinterpreted, and that the tests nevertheless pass by mere
> accident.
> > > > Note : the tests invoke "utf8::upgrade(...)", but this function is > > always available, doesn't need any "require utf8" or "use utf8".
> >


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.