This queue is for tickets about the Class-DBI-Plugin-Pager CPAN distribution.

Report information
The Basics
Id:
47497
Status:
resolved
Priority:
Low/Low

People
Owner:
majestic [...] cpan.org
Requestors:
gregoa [...] debian.org
Cc:
AdminCc:

BugTracker
Severity:
Critical
Broken in:
(no value)
Fixed in:
0.563



Subject: Test failures with newer SQL::Abstract
Date: Wed, 1 Jul 2009 18:57:33 +0200
To: bug-Class-DBI-Plugin-Pager@rt.cpan.org
From: gregor herrmann <gregoa@debian.org>
Hi, we're seeing failing tests in Debian that are probably caused by changes in SQL::Abstract. The full build log can be found at http://bugs.debian.org/531230 Probably using SQL::Abstract::Test (and requiring SQLA >= 1.50) would help? Thanks in advanve for looking into this issue! gregor, Debian Perl Group -- .''`. http://info.comodo.priv.at/ -- GPG Key IDs: 0x00F3CFE4, 0x8649AA06 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/ `- NP: Natalie Merchant: Thank You

Message body not shown because it is not plain text.

Subject: [rt.cpan.org #47497] [PATCH] Test failures with newer SQL::Abstract
Date: Wed, 07 Apr 2010 22:44:56 +0900
To: bug-Class-DBI-Plugin-Pager@rt.cpan.org
From: Ansgar Burchardt <ansgar@43-1.org>
Hi, attached is the patch applied in Debian to solve this problem. Starting with version 1.61, SQL::Abstract also dislikes the use of "=>" instead of the correct ">=". The patch addresses this issue as well. Please consider applying it in the next release. Regards, Ansgar
Author: Tim Retout <tim@retout.co.uk> Author: Ansgar Burchardt <ansgar@43-1.org> Bug-Debian: http://bugs.debian.org/531230 Bug-Debian: http://bugs.debian.org/576644 Last-Update: 2010-04-07 Description: SQL::Abstract 1.55 outputs cleaner SQL, so update 02main.t to expect it. --- libclass-dbi-plugin-pager-perl.orig/t/02.main.t +++ libclass-dbi-plugin-pager-perl/t/02.main.t @@ -105,7 +105,7 @@ $conf{ where } = [ age => {'<=', 80}, - age => {'=>', 20}, + age => {'>=', 20}, city => 'Jerusalem', ]; @@ -116,7 +116,7 @@ lives_ok { @results = $pager->search_where } 'search_where'; is_deeply( \@results, [ @dataset, 'TestApp', - '( ( age <= ? ) AND ( age => ? ) AND ( city = ? ) ) ORDER BY fig LIMIT 10, 5', + '( ( age <= ? AND age >= ? AND city = ? ) ) ORDER BY fig LIMIT 10, 5', '80', '20', 'Jerusalem', ], 'arrayref where (named args) results' ); @@ -130,7 +130,7 @@ $conf{ where } = [ age => {'<=', 80}, - age => {'=>', 20}, + age => {'>=', 20}, city => 'Jerusalem', ]; @@ -142,7 +142,7 @@ lives_ok { @results = $pager->search_where } 'search_where'; is_deeply( \@results, [ @dataset, 'TestApp', - '( ( age <= ? ) AND ( age => ? ) AND ( city = ? ) ) ORDER BY fig ROWS 10 TO 15', + '( ( age <= ? AND age >= ? AND city = ? ) ) ORDER BY fig ROWS 10 TO 15', '80', '20', 'Jerusalem', ], 'arrayref where (positional args) results' );
RT-Send-CC: ansgar@43-1.org
Thanks. Your patch has been applied.


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.