Skip Menu |
 

This queue is for tickets about the Net-OAuth CPAN distribution.

Report information
The Basics
Id: 47453
Status: open
Priority: 0/
Queue: Net-OAuth

People
Owner: Nobody in particular
Requestors: CATONE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Probably incorrect 'check'
Download (untitled) / with headers
text/plain 489b
IMHO, message->check should be called during verify/sign step, not during constructor. Currently it is impossible to create object and fill required field after that. Real example: when forming request object on provider side, we first need to parse request - to get consumer key, then get consumer secret from our storage, and only then we could create request object, which will parse request again. Currently, I workarounded it with dummy consumer secret - but it's ugly. Do you agree?
Download (untitled) / with headers
text/plain 761b
Yes, I agree that having that check during the constructor phase doesn't make sense for a provider. I'll figure out a solution and update Net::OAuth in the next day or two. Thanks for the feedback! k. On Tue Jun 30 05:19:44 2009, CATONE wrote: Show quoted text
> IMHO, message->check should be called during verify/sign step, not > during constructor. Currently it is impossible to create object and fill > required field after that. > Real example: > when forming request object on provider side, we first need to parse > request - to get consumer key, then get consumer secret from our > storage, and only then we could create request object, which will parse > request again. > Currently, I workarounded it with dummy consumer secret - but it's ugly. > > Do you agree?
Thank you very much.
Download (untitled) / with headers
text/plain 327b
Hi, I encounter the same problem with the need to use dummy value while constructing the object. It would be maybe cleaner to have the check performed only on the sign/verify call if any. This is not a blocking issue but it would still be a little simpler and more efficient to use with such a modification. Thanks, Mathias


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.