Skip Menu |
 

This queue is for tickets about the autodie CPAN distribution.

Report information
The Basics
Id: 47437
Status: resolved
Priority: 0/
Queue: autodie

People
Owner: PJF [...] cpan.org
Requestors: frequency [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 2.00
Fixed in: (no value)



Subject: Pod-Coverage Test Failure Without Sub::Identify
Download (untitled) / with headers
text/plain 714b
Hi: Presumably you didn't notice this because you have Sub::Identify installed. However, if you don't, and if you run your author tests (yeah, I know they're just author tests, which is why this is marked wishlist) then you get failures in Pod-Coverage because it expects get_code_info to be documented, since it is then defined in your package (using code copied from Sub::Identify). Installing Sub::Identify fixes the issue, but perhaps it would be useful to have Test::Pod::Coverage ignore that subroutine, maybe using the 'trustme' feature? Cheers, Jonathan (For what it's worth, this "bug" was uncovered while packaging your software for Debian, where our policy is to run all author tests during build)
Download (untitled) / with headers
text/plain 843b
G'day Jonathan, On Mon Jun 29 12:15:52 2009, FREQUENCY wrote: Show quoted text
> Presumably you didn't notice this because you have Sub::Identify > installed.
Indeed I do! (At least on the box where I run the author tests.) Well-spotted! Show quoted text
> Installing Sub::Identify fixes the issue, but perhaps it would be > useful to have Test::Pod::Coverage ignore that subroutine, maybe > using the 'trustme' feature?
Thanks! Fixed as 21a03de (with attribution) and pushed to github[1]. This will be released with autodie 2.01. On that note, 2.01 will probably be released in the next 48 hours, to address some internal changes that are coming up with Perl 5.10.1. If it causes you any other packaging problems, do let me know, and I'll do my best to make sure they're fixed upstream before release. All the best, Paul [1] http://github.com/pfenwick/autodie
From: frequency [...] cpan.org
Download (untitled) / with headers
text/plain 1.3k
Thanks for the fix Paul. On Mon Jun 29 12:37:12 2009, PJF wrote: Show quoted text
> G'day Jonathan, > > On Mon Jun 29 12:15:52 2009, FREQUENCY wrote: >
> > Presumably you didn't notice this because you have Sub::Identify > > installed.
> > Indeed I do! (At least on the box where I run the author tests.) > Well-spotted! >
> > Installing Sub::Identify fixes the issue, but perhaps it would be > > useful to have Test::Pod::Coverage ignore that subroutine, maybe > > using the 'trustme' feature?
> > Thanks! Fixed as 21a03de (with attribution) and pushed to github[1]. > This will be released with autodie 2.01. > > On that note, 2.01 will probably be released in the next 48 hours, to > address some internal changes that are coming up with Perl 5.10.1. If > it causes you any other packaging problems, do let me know, and I'll do > my best to make sure they're fixed upstream before release.
There are no other issues as far as I can tell. This wasn't really an issue since I just depended on Sub::Identify (which was conveniently already packaged for Debian). I hope you're not doing another release just the sake of resolving this bug; it's really not that big a deal (since Test::Pod::Coverage will only be an author test anyway). The upside of this is that Sub::Identify uses an XS implementation from what I can tell. Thanks for the quick turnaround!
Sorry, I'm not sure why the RT decided to change the bug status back to open.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.