Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 47400
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: mschwern [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.33_04
Fixed in: (no value)

Attachments
0001-Change-the-manifest-action-to-use-the-system-MANIFES.patch



Subject: We should not have our own MANIFEST.SKIP
Download (untitled) / with headers
text/plain 885b
The manifest action will write a default MANIFEST.SKIP. This is a static file inside Module::Build and not based on ExtUtils::Manifest. In some ways its ahead of EUM. In some ways its behind. For example, its missing .git so I keep making new MB distributions that want to put all of .git into the MANIFEST. We shouldn't be maintaining our own MANIFEST.SKIP. All general enhancements should go into EUM (I'll send them a patch). The rest should be stuck onto the end of the generic MANIFEST.SKIP. The attached patch does this. If the installed EUM supports #!include_default it will use that. Otherwise it copies the installed ExtUtils/MANIFEST.SKIP from @INC. Then it adds some MB specific items onto the end (which it did before) along with one to avoid the dist directory/tarball (again, it already did that). I commited a fix as r12946. David, please give it a review.
Subject: 0001-Change-the-manifest-action-to-use-the-system-MANIFES.patch
Looks fine to me. Closing this ticket and releasing 0.33_05 including this change.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.