Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 46991
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: mschwern [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.33
Fixed in: (no value)



Subject: Don't install PL_files
Download (untitled) / with headers
text/plain 511b
In perl5i I have... PL_files => { 'bin/perl5i.PL' => 'bin/perl5i' }, which works fine. Trouble is the .PL file gets installed! $ sudo ./Build install Password: Installing /usr/local/perl/5.10.0/lib/site_perl/5.10.0/perl5i.pm Installing /usr/local/perl/5.10.0/man/man3/perl5i.3 Installing /usr/local/perl/5.10.0/bin/perl5i Installing /usr/local/perl/5.10.0/bin/perl5i.PL Writing /usr/local/perl/5.10.0/lib/site_perl/5.10.0/darwin-thread-multi-2level/auto/perl5i/.packlist That ain't right.
Subject: Re: [rt.cpan.org #46991] Don't install PL_files
Date: Tue, 16 Jun 2009 08:54:36 -0400
To: bug-Module-Build [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 841b
On Tue, Jun 16, 2009 at 2:43 AM, Michael G Schwern via RT<bug-Module-Build@rt.cpan.org> wrote: Show quoted text
> In perl5i I have... > >    PL_files => { >        'bin/perl5i.PL' => 'bin/perl5i' >    }, > > which works fine.  Trouble is the .PL file gets installed!
I suspect you also don't have script_files => [ 'bin/perl5i' ] Documentation for "script_files" says that the default is any scripts in bin. There's nothing in the docs or code that makes an exception for .PL files. If you move your .PL to the top level and have this: PL_files => { 'perl5i.PL' -> 'bin/perl5i' } then I suspect it works as expected. I agree that it's odd to have .PL installed from bin, but that's "correct" as documented. If you want to make it DWIM, feel free to patch the last line of sub script_files() in M::B::Base and update the docs. -- David
Download (untitled) / with headers
text/plain 205b
Patched as r12852. While I was there I included some documentation on what a PL file is supposed to look like in r12851. It wasn't clear that it takes an argument or is supposed to write the file itself.
Download (untitled) / with headers
text/plain 103b
What's going to happen on case-insensitive filesystems? Might *.pl files look like *.PL files? -Ken
Subject: Re: [rt.cpan.org #46991] Don't install PL_files
Date: Tue, 16 Jun 2009 16:47:09 -0400
To: bug-Module-Build [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
Download (untitled) / with headers
text/plain 550b
On Tue, Jun 16, 2009 at 4:40 PM, Ken Williams via RT<bug-Module-Build@rt.cpan.org> wrote: Show quoted text
>       Queue: Module-Build >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=46991 > > > What's going to happen on case-insensitive filesystems?  Might *.pl > files look like *.PL files?
M::B only scans for PL files in lib so it's only an issue if someone puts a *.pl file under lib. I suspect that's rare, but it has happened in at least one case: #45406: test run from lib/ -- https://rt.cpan.org/Ticket/Display.html?id=45406 -- David
Fixed in trunk


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.