Skip Menu |
 

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 46808
Status: resolved
Priority: 0/
Queue: DBIx-Class

People
Owner: Nobody in particular
Requestors: Support [...] RoxSoft.co.uk
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.08103
Fixed in: 0.08108



Subject: DBIx::Class::Schema::ddl_filename method signature changed
Download (untitled) / with headers
text/plain 346b
In DBIx::Class 0.8009 the Schema::ddl_filename method had a signature of $type, $dir, $version, $pversion. In 0.8103 this has changed to $type, $version, $dir $preversion. This change is not backwardly compatible. From the schema docs "You may override this method in your schema if you wish to use a different format.", so it is a public method
Have attached doc patch
Download Schema.pm.patch
text/x-diff 631b
--- Schema.pm 2009-06-09 22:21:39.000000000 +0100 +++ Schema.pm 2009-06-09 22:35:42.000000000 +0100 @@ -1123,6 +1123,16 @@ You may override this method in your schema if you wish to use a different format. +Prior to DBIx::Class version 0.08100 this method had this signature: + + my $filename = $table->ddl_filename($type, $dir, $version, $preversion) + +Variables C<$dir> and C<$version> where reversed. To maintain backward +compatibility use the current method signature and add this line to any +override methods + + ($dir, $version) = ($version, $dir) if ($DBIx::Class::VERSION < 0.08100); + =cut sub ddl_filename {
Download (untitled) / with headers
text/plain 157b
On Tue Jun 09 17:42:34 2009, PJFL wrote: Show quoted text
> Have attached doc patch
Committed with some changed at http://dev.catalyst.perl.org/svnweb/bast/revision?rev=6803


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.