Skip Menu |
 

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 46723
Status: resolved
Priority: 0/
Queue: DBIx-Class

People
Owner: Nobody in particular
Requestors: TIMB [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: 0.08104

Attachments
InflateColumn-DateTime-columnname.patch



Subject: New "please put it directly into the columns definition" warnings could be more helpful [PATCH]
Download (untitled) / with headers
text/plain 237b
New "please put it directly into the columns definition" warnings could be more helpful by including the specific column name. I've attached patch that does that. Adding the table name would also be handy, but this was enough for me.
Subject: InflateColumn-DateTime-columnname.patch
Index: /home/tim/trunk/perl/cpan/lib/perl5/DBIx/Class/InflateColumn/DateTime.pm =================================================================== --- /home/tim/trunk/perl/cpan/lib/perl5/DBIx/Class/InflateColumn/DateTime.pm (revision 5224) +++ /home/tim/trunk/perl/cpan/lib/perl5/DBIx/Class/InflateColumn/DateTime.pm (working copy) @@ -112,14 +112,14 @@ my $timezone; if ( defined $info->{extra}{timezone} ) { warn "Putting timezone into extra => { timezone => '...' } has been deprecated, ". - "please put it directly into the columns definition."; + "please put it directly into the '$column' column definition"; $timezone = $info->{extra}{timezone}; } my $locale; if ( defined $info->{extra}{locale} ) { warn "Putting locale into extra => { locale => '...' } has been deprecated, ". - "please put it directly into the columns definition."; + "please put it directly into the '$column' column definition"; $locale = $info->{extra}{locale}; } @@ -147,7 +147,7 @@ my $floating_tz_ok; if (defined $info->{extra}{floating_tz_ok}) { warn "Putting floating_tz_ok into extra => { floating_tz_ok => 1 } has been deprecated, ". - "please put it directly into the columns definition."; + "please put it directly into the '$column' column definition"; $floating_tz_ok = $info->{extra}{floating_tz_ok}; } $floating_tz_ok = $info->{floating_tz_ok} if defined $info->{floating_tz_ok};
Committed as revision 6559


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.