Skip Menu |
 

This queue is for tickets about the AutoXS-Header CPAN distribution.

Report information
The Basics
Id: 46552
Status: resolved
Priority: 0/
Queue: AutoXS-Header

People
Owner: Nobody in particular
Requestors: ron [...] rblasch.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: 1.00



Subject: Generated code should be C89
Download (untitled) / with headers
text/plain 136b
Came across this while building Class::XSAccessor with Visual C++ 9.0. Attached patch moves the declaration to the beginning of blocks.
Subject: decl.patch
Download decl.patch
text/x-diff 1k
--- lib\AutoXS\Header.pm.orig Sun May 17 11:17:27 2009 +++ lib\AutoXS\Header.pm Sun May 31 17:33:53 2009 @@ -48,11 +48,13 @@ /* implementation section */ I32 get_hashkey_index(const char* key, const I32 len) { + I32 index; + /* init */ if (AutoXS_reverse_hashkeys == NULL) AutoXS_reverse_hashkeys = newHV(); - I32 index = 0; + index = 0; if ( hv_exists(AutoXS_reverse_hashkeys, key, len) ) { SV** index_sv = hv_fetch(AutoXS_reverse_hashkeys, key, len, 0); @@ -126,6 +128,8 @@ } I32 get_internal_array_index(I32 object_ary_idx) { + I32 new_index; + if (AutoXS_reverse_arrayindices_length <= object_ary_idx) _resize_array_init( &AutoXS_reverse_arrayindices, &AutoXS_reverse_arrayindices_length, @@ -135,7 +139,7 @@ if (AutoXS_reverse_arrayindices[object_ary_idx] > -1) return AutoXS_reverse_arrayindices[object_ary_idx]; - I32 new_index = _new_internal_arrayindex(); + new_index = _new_internal_arrayindex(); AutoXS_reverse_arrayindices[object_ary_idx] = new_index; return new_index; }
Download (untitled) / with headers
text/plain 179b
Hi Ron, thanks for reporting this and particularly for providing the patch to go with it, too. I applied your patch and will release a new version shortly. Best regards, Steffen


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.