This queue is for tickets about the Class-Std CPAN distribution.

Report information
The Basics
Id:
46381
Status:
open
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
binarin [...] binarin.ru
Cc:
AdminCc:

BugTracker
Severity:
Normal
Broken in:
0.0.9
Fixed in:
(no value)



Subject: MODIFY_CODE_ATTRIBUTES consumes even unsupported attributes
MODIFY_CODE_ATTRIBUTES does uncoditional 'undef $attr' while iterating over attributes, and due to this always returns empty list. Later, closure created in import() doesn't call original MODIFY_CODE_ATTRIBUTES from target module, because @unhandled is always empty on second iteration. Patch to fix this problem is attached.
Subject: class-std-modify_code.patch
--- Std.pm-orig 2009-05-26 14:45:50.000000000 +0400 +++ Std.pm-orig-fixed 2009-05-26 23:42:32.000000000 +0400 @@ -199,6 +199,9 @@ elsif (exists $OVERLOADER_FOR{$attr}) { push @{$overload{$package}}, [$referent, $attr]; } + else { + next; + } undef $attr; } return grep {defined} @attrs;
Subject: Re: [rt.cpan.org #46381] MODIFY_CODE_ATTRIBUTES consumes even unsupported attributes
Date: Wed, 27 May 2009 06:49:16 +1000
To: bug-Class-Std@rt.cpan.org
From: Damian Conway <damian@conway.org>
Show quoted text
> MODIFY_CODE_ATTRIBUTES does uncoditional 'undef $attr' while iterating > over attributes, and due to this always returns empty list.
Thanks for the patch. This is now fixed for the next release. Damian
Subject: Re: [rt.cpan.org #46381] MODIFY_CODE_ATTRIBUTES consumes even unsupported attributes
Date: Tue, 26 May 2009 17:12:56 -0500
To: bug-Class-Std@rt.cpan.org
From: Dan Muey <dan@cpanel.net>
On May 26, 2009, at 3:50 PM, damian@conway.org via RT wrote:
Show quoted text
> Queue: Class-Std > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=46381 > >
>> MODIFY_CODE_ATTRIBUTES does uncoditional 'undef $attr' while >> iterating >> over attributes, and due to this always returns empty list.
> > Thanks for the patch. This is now fixed for the next release.
nuts I just realized I broke the repo URL, I'll have it up ASAP. in the mean time feel free to publish any updates and I'll modify the repo after the fact. Sorry about that!

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #46381] MODIFY_CODE_ATTRIBUTES consumes even unsupported attributes
Date: Wed, 27 May 2009 08:44:49 +1000
To: bug-Class-Std@rt.cpan.org
From: Damian Conway <damian@conway.org>
Show quoted text
> nuts I just realized I broke the repo URL, I'll have it up ASAP. in > the mean time feel free to publish any updates and I'll modify the > repo after the fact.
I believe you already have the latest update from me (which has that fix). If not, see attached. Thanks, Dan. Damian

Message body is not shown because sender requested not to inline it.

Subject: Re: [rt.cpan.org #46381] MODIFY_CODE_ATTRIBUTES consumes even unsupported attributes
Date: Tue, 26 May 2009 17:50:34 -0500
To: bug-Class-Std@rt.cpan.org
From: Dan Muey <webmaster@simplemood.com>
thanks! On May 26, 2009, at 5:45 PM, damian@conway.org via RT wrote:
Show quoted text
> Queue: Class-Std > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=46381 > >
>> nuts I just realized I broke the repo URL, I'll have it up ASAP. in >> the mean time feel free to publish any updates and I'll modify the >> repo after the fact.
> > I believe you already have the latest update from me (which has that > fix). > If not, see attached. > > Thanks, Dan. > > Damian > > <Std.pm>
Subject: Re: [rt.cpan.org #46381] MODIFY_CODE_ATTRIBUTES consumes even unsupported attributes
Date: Tue, 26 May 2009 17:51:52 -0500
To: bug-Class-Std@rt.cpan.org
From: Dan Muey <webmaster@simplemood.com>
perfect thanks, I'll push out an update and fix the repo URL, ASAP On May 26, 2009, at 5:45 PM, damian@conway.org via RT wrote:
Show quoted text
> Queue: Class-Std > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=46381 > >
>> nuts I just realized I broke the repo URL, I'll have it up ASAP. in >> the mean time feel free to publish any updates and I'll modify the >> repo after the fact.
> > I believe you already have the latest update from me (which has that > fix). > If not, see attached. > > Thanks, Dan. > > Damian > > <Std.pm>


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.