Skip Menu |
 

This queue is for tickets about the Devel-Ditto CPAN distribution.

Report information
The Basics
Id: 46365
Status: resolved
Priority: 0/
Queue: Devel-Ditto

People
Owner: Nobody in particular
Requestors: taro.nishino [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.05
Fixed in: (no value)



Subject: patches regarding Ditto.pm and output.t
Download (untitled) / with headers
text/plain 213b
Dear Andy, As you know, my cpan-testers report #3963090 shows that output.t failed under Win32. My patches regarding Ditto.pm and output.t are attached. Could you apply these patches? Best regards, Taro Nishino
Subject: Ditto.diff
Download Ditto.diff
text/x-diff 387b
--- Ditto.pm.orig Tue May 26 10:26:20 2009 +++ Ditto.pm Tue May 26 10:49:56 2009 @@ -46,6 +46,7 @@ use warnings; use strict; +use File::Spec; sub import { my $class = shift; @@ -86,6 +87,7 @@ sub _logbit { my $self = shift; my ( $pkg, $file, $line ) = $self->_caller(); + $file = File::Spec->canonpath($file); return "[$pkg, $file, $line] "; }
Subject: output.diff
Download output.diff
text/x-diff 825b
--- output.t.orig Tue May 26 10:10:29 2009 +++ output.t Tue May 26 10:45:30 2009 @@ -11,10 +11,10 @@ \my $in, \my $out, \my $err or die "Failed: $?"; -is $out, "[main, t/myprog.pl, 9] This is regular text\n" - . "[MyPrinter, t/lib/MyPrinter.pm, 7] Hello, World\n", 'STDOUT'; -is $err, "[main, t/myprog.pl, 10] This is a warning\n" - . "[MyPrinter, t/lib/MyPrinter.pm, 8] Whappen?\n", 'STDERR'; +is $out, "[main, " . File::Spec->canonpath("t/myprog.pl") . ", 9] This is regular text\n" + . "[MyPrinter, " . File::Spec->canonpath("t/lib/MyPrinter.pm") . ", 7] Hello, World\n", 'STDOUT'; +is $err, "[main, " . File::Spec->canonpath("t/myprog.pl") . ", 10] This is a warning\n" + . "[MyPrinter, " . File::Spec->canonpath("t/lib/MyPrinter.pm") . ", 8] Whappen?\n", 'STDERR'; # vim:ts=2:sw=2:et:ft=perl
Thanks - patches applied and released as 0.06.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.