Skip Menu |
 

This queue is for tickets about the namespace-clean CPAN distribution.

Report information
The Basics
Id: 45637
Status: resolved
Priority: 0/
Queue: namespace-clean

People
Owner: Nobody in particular
Requestors: danjou [...] mac.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 0.09
  • 0.10
  • 0.11
Fixed in: (no value)



Subject: conflicts with Devel::Cover
Download (untitled) / with headers
text/plain 730b
The test below fails (without Devel::Cover, it passes). HARNESS_PERL_SWITCHES=-MDevel::Cover prove test.t The error message is: # Failed test 'use Foo;' # at test.t line 2. # Tried to use 'Foo'. # Error: Can't use an undefined value as a symbol reference at /Users/danjou/perl5/lib/perl5/namespace/clean.pm line 170. # Compilation failed in require at (eval 27)[/Users/danjou/perl5/lib/perl5/Test/More.pm:745] line 2. # BEGIN failed--compilation aborted at (eval 27)[/Users/danjou/perl5/lib/perl5/Test/More.pm:745] line 2. # Looks like you failed 1 test of 1. use.t: use Test::More tests => 1; use_ok 'Foo'; Foo.pm: package Foo; use Moose; use namespace::clean; no Moose; 1;
Subject: Re: [rt.cpan.org #45637] conflicts with Devel::Cover
Date: Sat, 2 May 2009 04:29:01 +0200
To: Nobuo Danjou via RT <bug-namespace-clean [...] rt.cpan.org>
From: Florian Ragwitz <rafl [...] debian.org>
Download (untitled) / with headers
text/plain 553b
On Fri, May 01, 2009 at 10:18:01PM -0400, Nobuo Danjou via RT wrote: Show quoted text
> Foo.pm: > > package Foo; > use Moose; > use namespace::clean; > > no Moose; > > 1;
Thanks for the report. It will be looked into, however it won't be a huge priority, given that you can easily make the test pass by not explicitly inimporting the Moose keywords using 'no Moose' before namespace::clean gets a chance to do it. There's really no point in doing that. -- BOFH excuse #246: It must have been the lightning storm we had (yesterday) (last week) (last month)
Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #45637] conflicts with Devel::Cover
Date: Sun, 3 May 2009 11:57:30 +0900
To: bug-namespace-clean [...] rt.cpan.org
From: Nobuo Danjou <nobuo.danjou [...] gmail.com>
Download (untitled) / with headers
text/plain 1016b
Thank you for quick response and advices. I'll do so. -nd On Sat, May 2, 2009 at 11:30 AM, Florian Ragwitz via RT <bug-namespace-clean@rt.cpan.org> wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=45637 > > > On Fri, May 01, 2009 at 10:18:01PM -0400, Nobuo Danjou via RT wrote:
>> Foo.pm: >> >>   package Foo; >>   use Moose; >>   use namespace::clean; >> >>   no Moose; >> >>   1;
> > Thanks for the report. It will be looked into, however it won't be a > huge priority, given that you can easily make the test pass by not > explicitly inimporting the Moose keywords using 'no Moose' before > namespace::clean gets a chance to do it. There's really no point in > doing that. > > > -- > BOFH excuse #246: > It must have been the lightning storm we had (yesterday) (last week) > (last month) > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.6 (GNU/Linux) > > iD8DBQFJ+6/sdC8qQo5jWl4RAlReAKCCmbSlJvaFLq4XkHxRuvhLG//7AwCfRySL > ytVmyLlb3IRVIWWSLPr6mN4= > =WOrz > -----END PGP SIGNATURE----- > >
Download (untitled) / with headers
text/plain 758b
On Fri May 01 22:30:01 2009, FLORA wrote: Show quoted text
> On Fri, May 01, 2009 at 10:18:01PM -0400, Nobuo Danjou via RT wrote:
> > Foo.pm: > > > > package Foo; > > use Moose; > > use namespace::clean; > > > > no Moose; > > > > 1;
> > Thanks for the report. It will be looked into, however it won't be a > huge priority, given that you can easily make the test pass by not > explicitly inimporting the Moose keywords using 'no Moose' before > namespace::clean gets a chance to do it. There's really no point in > doing that. > >
I was actually just encountering the same issue and then decided to look at the bug reports. Do you think you may want to add a section to the POD for Moose people to remember to not put "no Moose;" in namespace::clean'd modules?


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.