Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 45111
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: DStaal [...] usa.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.32
Fixed in: 0.32_01



Subject: Module::Build::Compat's 'traditional' form tries to use Module::Build.
Download (untitled) / with headers
text/plain 380b
Module::Build::Compat's 'traditional' makefile fails to exclude Build.PL (if it is present) from the build process, requiring it to either be deleted from the archive or have someone manually edit the makefile to exclude it. This makes it somewhat difficult to bundle modules with both Build.PL and Makefile.PL, as the latter has to be edited manually after being auto-generated.
Subject: Re: [rt.cpan.org #45111] Module::Build::Compat's 'traditional' form tries to use Module::Build.
Date: Fri, 17 Apr 2009 11:12:01 -0700
To: bug-Module-Build [...] rt.cpan.org
From: Eric Wilhelm <enobacon [...] gmail.com>
Download (untitled) / with headers
text/plain 325b
Hi Daniel, # from Daniel T. Staal via RT on Friday 17 April 2009 10:59: Show quoted text
>Module::Build::Compat's 'traditional' makefile fails to exclude > Build.PL (if it is present) from the build process
Sorry, I can't reproduce that with 0.32. Can you provide an example Build.PL (or tarball) which illustrates the bug? Thanks, Eric
Download (untitled) / with headers
text/plain 494b
Eric, might this have to do with the following commit? ------------------------------------------------------------------------ r12568 | dagolden | 2009-03-03 22:25:42 -0600 (Tue, 03 Mar 2009) | 6 lines Module::Build::Compat had stopped adding PL_FILES=>{} if PL_files wasn't set in Build.PL; restored old behavior. Also fixed buggy tests that weren't detecting this bug and changed ancient documentation suggesting setting PL_FILES manually as that is irrelevant now that this works again.
Subject: Re: [rt.cpan.org #45111] Module::Build::Compat's 'traditional' form tries to use Module::Build.
Date: Fri, 17 Apr 2009 15:47:52 -0400 (EDT)
To: bug-Module-Build [...] rt.cpan.org
From: "Daniel Staal" <DStaal [...] usa.net>
Download (untitled) / with headers
text/plain 859b
On Fri, April 17, 2009 2:12 pm, Eric Wilhelm via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=45111 > > > Hi Daniel, > > # from Daniel T. Staal via RT on Friday 17 April 2009 10:59:
>>Module::Build::Compat's 'traditional' makefile fails to exclude >> Build.PL (if it is present) from the build process
> > Sorry, I can't reproduce that with 0.32. Can you provide an example > Build.PL (or tarball) which illustrates the bug?
Sure, attached. (From a recent package I pushed around the office to notice this.) I should note that I ran the attached tarball under Perl 5.8.5, which has ExtUtils::MakeMaker 6.17 (I assume...). It's possible that the ancient platform makes a difference. (I didn't bother to run the test suite, so I didn't have to upgrade anything.) The tarball was _built_ using 5.10, and Module::Build 0.32. Daniel T. Staal
Download DSES-1.0.tar.gz
application/x-gzip 10k

Message body not shown because it is not plain text.

It's a bug that was fixed in 0.32_01. Regards, David
Subject: Module::Build::Compat's 'traditional' form -- older ExtUtils::MakeMaker runs Build.PL
Download (untitled) / with headers
text/plain 565b
On Fri Apr 17 15:48:12 2009, DSTAAL wrote: Show quoted text
> I should note that I ran the attached tarball under Perl 5.8.5, > which has ExtUtils::MakeMaker 6.17 (I assume...). It's possible > that the ancient platform makes a difference.
Indeed. This is why I couldn't replicate it on M::B 0.32 here. The newer ExtUtils::MakeMaker specifically ignores Build.PL, but we needed to have the PL_FILES=>{} to avoid tripping up older EU::MM. As Ken and David noted, this is fixed in svn r12568 and we're currently vetting 0.32_01 toward the official 0.33 release. Thanks, Eric


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.