Skip Menu |
 

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 44796
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: Nobody in particular
Requestors: RIVY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: Module::CPANTS::Kwalitee::Manifest broken for MANIFESTs containing files with spaces
Download (untitled) / with headers
text/plain 980b
My Win32 builds containing file names with internal whitespace are incorrectly seen as violating the 'manifest_matches_dist' kwalitee metric (see Win32::CommandLine v0.4.3.50 or earlier). Since ExtUtils::Manifest v1.52+, MANIFEST file names can have internal whitespace if surrounded by single quotes. The current version of Module::CPANTS::Kwalitee::Manifest parses files containing whitespace incorrectly. Note: [from ExtUtils::Manifest:325:333] # filename may contain spaces if enclosed in '' # (in which case, \\ and \' are escapes) if (($file, $comment) = /^'(\\[\\']|.+)+'\s*(.*)/) { $file =~ s/\\([\\'])/$1/g; } else { ($file, $comment) = /^(\S+)\s*(.*)/; } next unless $file; The broken code is at line #32: [Module::CPANTS::Kwalitee::Manifest.pm:32] s/\s.*$//; # strip file comments It should be changed to something like: if (s/^'(\\[\\']|.+)+'\s*.*/$1/) { s/\\([\\'])/$1/g; } else { s/\s.*$//; } # strip quotes and comments Thanks. - Roy Ivy
fixed in 0.87


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.