Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 4412
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: djerius [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.21
Fixed in: (no value)



Subject: Bad interaction with Test::Harness 2.36
Download (untitled) / with headers
text/plain 1.6k
There are a couple of problems when used in conjunction with Test::Harness 2.36. The first is that "make test" hangs. This is caused by Module::Build::Base::ACTION_test setting $ENV{HARNESS_PERL_SWITCHES} to an empty string if $harness_switches is empty. This confuses Test::Harness, which looks to see if that environmental variable is defined (not if its empty). It thus builds a command line that looks like this: perl "-w" "" <test file name> The empty third argument causes perl to read the program from STDIN, which of course isn't what's required here. Thus it hangs. Something like this cures that ailment (Base.pm, line 1015) delete $ENV{HARNESS_PERL_SWITCHES} if $ENV{HARNESS_PERL_SWITCHES} eq ''; The next problem is that the testdb target fails with messages like: t/basic.........Can't open perl script " -w -d": No such file or directory t/basic.........dubious Test returned status 2 (wstat 512, 0x200) Note the leading space in the " -w -d" option list, which is there so that when appended to an existing set of switches the appropriate space is inserted. however, for some reason there is no existing set. I modified the code in ACTION_test to look like this, and it seems to work (it at least runs the code, rather than failing): my $harness_switches = $p->{debugger} ? '-w -d' : ''; local $Test::Harness::switches = join( ' ', ($Test::Harness::switches || ()), $harness_switches); local $Test::Harness::Switches = join( ' ', ($Test::Harness::Switches || ()), $harness_switches); local $ENV{HARNESS_PERL_SWITCHES} = join( ' ', ($ENV{HARNESS_PERL_SWITCHES} || ()), $harness_switches); Thanks, Diab
Download (untitled) / with headers
text/plain 335b
Show quoted text
> This confuses Test::Harness, > which looks to see if that environmental variable is defined (not if > its empty). It thus builds a command line that looks like this:
2.37_01 and beyond will check for emptiness as well as definedness. There's no reason that it should behave poorly if HARNESS_PERL_SWITCHES is blank by defined.
Okay, this is now fixed in Module::Build's CVS and will be part of the next release. -Ken


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.