Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id:
43754
Status:
open
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
user42 [...] zip.com.au
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)

Attachments
ProhibitReusedNames.run.multi-package-our.diff



Subject: ProhibitReusedNames vs "our" of multi-package file
Date: Mon, 02 Mar 2009 08:50:59 +1100
To: bug-Perl-Critic@rt.cpan.org
From: Kevin Ryde <user42@zip.com.au>
With the current perlcritic cvs I noticed ProhibitReusedNames objects to multiple "our @ISA" for multiple packages in a single file, where I hoped that would be allowed. Failing bit of .run below ...
Index: ProhibitReusedNames.run =================================================================== --- ProhibitReusedNames.run (revision 3202) +++ ProhibitReusedNames.run (working copy) @@ -270,6 +270,17 @@ #----------------------------------------------------------------------------- +## name Our in new package +## failures 0 +## cut + +package Foo; +our @ISA; +package Bar; +our @ISA; + +#----------------------------------------------------------------------------- + ############################################################################## # $URL$ # $Date$
Subject: Re: [rt.cpan.org #43754] ProhibitReusedNames vs "our" of multi-package file
Date: Sun, 01 Mar 2009 16:12:52 -0600
To: bug-Perl-Critic@rt.cpan.org
From: Elliot Shank <perl@galumph.com>
Kevin Ryde via RT wrote:
Show quoted text
> With the current perlcritic cvs I noticed ProhibitReusedNames objects to > multiple "our @ISA" for multiple packages in a single file, where I > hoped that would be allowed. Failing bit of .run below ...
Well, don't put multiple packages in a single file, then. :] Seriously, handling of multiple packages in a single file is one of the big TODOs for P::C in general.


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.