Skip Menu |
 

This queue is for tickets about the Template-Plugin-JSON CPAN distribution.

Report information
The Basics
Id: 43506
Status: resolved
Priority: 0/
Queue: Template-Plugin-JSON

People
Owner: Nobody in particular
Requestors: frank.wiegand [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.04
Fixed in: (no value)



Subject: warning typo
Download (untitled) / with headers
text/plain 710b
This is against 0.04: diff --git a/lib/Template/Plugin/JSON.pm b/lib/Template/Plugin/JSON.pm index dbe4612..6d63e32 100644 --- a/lib/Template/Plugin/JSON.pm +++ b/lib/Template/Plugin/JSON.pm @@ -33,7 +33,7 @@ sub BUILDARGS { my ( $class, $c, $args ) = @_; unless ( ref $args ) { - warn "Single arguent form is deprecated, this module always uses JSON/JSON::XS now"; + warn "Single argument form is deprecated, this module always uses JSON/JSON::XS now"; $args = {}; } It's also annoying, that [% USE JSON %] issues this warning. Maybe it should only be thrown if there is really a single argument (that is not an empty list). Thanks, Frank
Subject: warning typo & inaccuracies.
From: dekimsey [...] gmail.com
./agree The warning is rather inaccurate when no arguments are provided (as per example).
Cool, thanks. BTW, I see you're using git- you can just patch with http://github.com/nothingmuch/template-plugin-json/ if you like. If not I will apply the diff and release tomorrow (i'm a little swamped right now) after I fix the no args case as well. I should update the docs to point at github I guess... On Sun Feb 22 08:17:03 2009, frank.wiegand wrote: Show quoted text
> This is against 0.04: > > diff --git a/lib/Template/Plugin/JSON.pm b/lib/Template/Plugin/JSON.pm > index dbe4612..6d63e32 100644 > --- a/lib/Template/Plugin/JSON.pm > +++ b/lib/Template/Plugin/JSON.pm > @@ -33,7 +33,7 @@ sub BUILDARGS { > my ( $class, $c, $args ) = @_; > > unless ( ref $args ) { > - warn "Single arguent form is deprecated, this module > always uses JSON/JSON::XS now"; > + warn "Single argument form is deprecated, this module > always uses JSON/JSON::XS now"; > $args = {}; > } > > > It's also annoying, that [% USE JSON %] issues this warning. Maybe it > should only be thrown if there is really a single argument (that is not > an empty list). > > > Thanks, Frank
0.05 released


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.