Skip Menu |
 

This queue is for tickets about the POE-Component-SmokeBox CPAN distribution.

Report information
The Basics
Id: 43027
Status: resolved
Worked: 50 min
Priority: 0/
Queue: POE-Component-SmokeBox

People
Owner: BINGOS [...] cpan.org
Requestors: oxdeadbeef [...] pit-of-despair.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.12
Fixed in: (no value)



Subject: typos in mini-smokebox.pl and SmokeBox.pm
Download (untitled) / with headers
text/plain 413b
Distribution: POE-Component-SmokeBox-0.12 Perl: v5.8.8 built for x86_64-linux-gnu-thread-multi OS: Linux beast 2.6.24-23-rt #1 SMP PREEMPT RT Thu Nov 27 19:40:04 UTC 2008 x86_64 GNU/Linux (ubuntu-8.04) There are a few typoes in examples/mini-smokebox.pl and lib/POE/Component/SmokeBox.pm that prevent PoCo::SmokeBox from running properly. The biggest is in SmokeBox.pm where submit() calls the wrong event name
Subject: POE-Component-SmokeBox-0.12.patch
diff -urN POE-Component-SmokeBox-0.12/examples/mini-smokebox.pl POE-Component-SmokeBox-0.12-/examples/mini-smokebox.pl --- POE-Component-SmokeBox-0.12/examples/mini-smokebox.pl 2008-09-06 14:27:44.000000000 -0400 +++ POE-Component-SmokeBox-0.12-/examples/mini-smokebox.pl 2009-02-04 14:13:13.000000000 -0500 @@ -64,7 +64,7 @@ } sub _results { - my $result = $_[ARG0]; + my $results = $_[ARG0]; print $_, "\n" for map { @{ $_->{log} } } $results->{result}->results(); undef; } diff -urN POE-Component-SmokeBox-0.12/lib/POE/Component/SmokeBox.pm POE-Component-SmokeBox-0.12-/lib/POE/Component/SmokeBox.pm --- POE-Component-SmokeBox-0.12/lib/POE/Component/SmokeBox.pm 2009-02-04 05:56:43.000000000 -0500 +++ POE-Component-SmokeBox-0.12-/lib/POE/Component/SmokeBox.pm 2009-02-04 14:17:06.000000000 -0500 @@ -131,7 +131,7 @@ sub submit { my $self = shift; - $poe_kernel->call( $self->{session_id}, '_submit', @_ ); + $poe_kernel->call( $self->{session_id}, 'submit', @_ ); } sub _submit { @@ -208,9 +208,9 @@ POE::Session->create( package_states => [ - 'main' => [ qw(_start _stop _results _recent) ], + 'main' => [ qw(_start _stop _results) ], ], - heap => { perl => $perl, pending => { @ARGV }, + heap => { perl => $perl, pending => [ @ARGV ] }, ); $poe_kernel->run(); @@ -235,7 +235,7 @@ } sub _results { - my $result = $_[ARG0]; + my $results = $_[ARG0]; print $_, "\n" for map { @{ $_->{log} } } $results->{result}->results(); undef; }
Download (untitled) / with headers
text/plain 226b
Hi, According to my records this was fixed as of version 0.14 0.14 Thu Feb 5 22:36:53 GMT 2009 - [rt #43027] Applied patch from oxdeadbeef - Fixed refcount management in JobQueue - Overhauled the testsuite. Many thanks.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.