Skip Menu |
 
Update: The rt.cpan.org bug tracker service is no longer shutting down.

This queue is for tickets about the Spreadsheet-XLSX CPAN distribution.

Report information
The Basics
Id: 42735
Status: resolved
Priority: 0/
Queue: Spreadsheet-XLSX

People
Owner: Nobody in particular
Requestors: HMBRAND [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.08
Fixed in: (no value)



Subject: unmatched expression causes errors
Download (untitled) / with headers
text/plain 1.3k
if the match fails, $1 is still assigned to $sty, which causes errors like these: Use of uninitialized value $1 in numeric gt (>) at /pro/lib/perl5/ site_perl/5.10.0/Spreadsheet/XLSX.pm line 155. Argument "A" isn't numeric in numeric gt (>) at /pro/lib/perl5/ site_perl/5.10.0/Spreadsheet/XLSX.pm line 155. Argument "D" isn't numeric in numeric gt (>) at /pro/lib/perl5/ site_perl/5.10.0/Spreadsheet/XLSX.pm line 155. Argument "E" isn't numeric in numeric gt (>) at /pro/lib/perl5/ site_perl/5.10.0/Spreadsheet/XLSX.pm line 155. I Prose the following patch (also attached): --8<--- --- XLSX.pm 2009-01-05 19:43:26.000000000 +0100 +++ /pro/lib/perl5/site_perl/5.10.0/Spreadsheet/XLSX.pm 2009-01-08 08:30:57.000000000 +0100 @@ -148,11 +148,9 @@ sub new { $row = $3 - 1; - $s = /t=\"s\"/ ? 1 : 0; - $s2 = /t=\"str\"/ ? 1 : 0; - /s="([^"]*)"/; #" - - $sty = $1>0 ? $1 : 0 ; + $s = m/t=\"s\"/ ? 1 : 0; + $s2 = m/t=\"str\"/ ? 1 : 0; + $sty = m/s="([0-9]+)"/ ? $1 : 0; } elsif (/^<v/) { $flag = 1; -->8---
Subject: XLSX.diff
Download XLSX.diff
text/x-diff 466b
--- lib/Spreadsheet/XLSX.pm.org 2009-01-05 19:43:26.000000000 +0100 +++ lib/Spreadsheet/XLSX.pm 2009-01-08 08:30:57.000000000 +0100 @@ -148,11 +148,9 @@ sub new { $row = $3 - 1; - $s = /t=\"s\"/ ? 1 : 0; - $s2 = /t=\"str\"/ ? 1 : 0; - /s="([^"]*)"/; #" - - $sty = $1>0 ? $1 : 0 ; + $s = m/t=\"s\"/ ? 1 : 0; + $s2 = m/t=\"str\"/ ? 1 : 0; + $sty = m/s="([0-9]+)"/ ? $1 : 0; } elsif (/^<v/) { $flag = 1;
Subject: fixed
See v.0.0.9


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.