This queue is for tickets about the CPAN CPAN distribution.

Report information
The Basics
Id:
42262
Status:
open
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
jhoger [...] pobox.com
Cc:
AdminCc:

BugTracker
Severity:
Important
Broken in:
1.9301
Fixed in:
(no value)



Subject: When guessing utility filenames, CPAN doesn't quote the nmake path.
When first running CPAN on Win32, if you have Visual Studio 2008 Express Edition compiler installed in the default path, then cpan detects nmake.exe location correctly, but fails to quote it in Config.pm. So attempts to install, say, Bundle::CPAN fail miserably since it tries to run the utility without quoting the name at runtime. Logic should be added to either quote the name when it is autodetected, or later when it is used. as a work around, you can not let the autodetection run or you can quote the few things that need it after the fact like: cpan o conf make '"C:\Program Files\Microsoft Visual Studio 9.0\VC\BIN\nmake.EXE"' o conf make_install_make_command '"C:\Program Files\Microsoft Visual Studio 9.0\VC\BIN\nmake.EXE"' o conf commit This article is what helped me resolve the problem for my own broken installation: http://www.perlmonks.org/?node_id=530600
Subject: Re: [rt.cpan.org #42262] When guessing utility filenames, CPAN doesn't quote the nmake path.
Date: Sat, 10 Jan 2009 12:58:04 -0500
To: bug-CPAN@rt.cpan.org
From: "David Golden" <dagolden@cpan.org>
Andreas -- do you think we should fix this in FirstTime.pm or when commands are run?

-- David
Subject: Re: [rt.cpan.org #42262] When guessing utility filenames, CPAN doesn't quote the nmake path.
Date: Sat, 10 Jan 2009 21:22:30 +0100
To: bug-CPAN@rt.cpan.org
From: andreas.koenig.7os6VVqR@franz.ak.mind.de (Andreas J. Koenig)
Show quoted text
>>>>> On Sat, 10 Jan 2009 12:58:30 -0500, "David Golden via RT" <bug-CPAN@rt.cpan.org> said:
Show quoted text
> Andreas -- do you think we should fix this in FirstTime.pm or when commands > are run?
As late as possible. Keep all variables as real and true as possible and adjust them to outside needs when the outside needs them. But I do not understand why CPAN::Distribution::_make_command() and the safe-quote() in there do not catch that correctly nowadays. I thought we'd fixed that. -- andreas
Subject: Re: [rt.cpan.org #42262] When guessing utility filenames, CPAN doesn't quote the nmake path.
Date: Sat, 10 Jan 2009 16:22:02 -0500
To: bug-CPAN@rt.cpan.org
From: "David Golden" <dagolden@cpan.org>
On Sat, Jan 10, 2009 at 3:22 PM, (Andreas J. Koenig) via RT <bug-CPAN@rt.cpan.org> wrote:
Show quoted text
But I do not understand why CPAN::Distribution::_make_command() and
the safe-quote() in there do not catch that correctly nowadays. I
thought we'd fixed that.

I'll have to look into that further.

In my quick scan I did note line 2353 of CPAN::Distribution calls safe_quote as a function, not a class method.  That's probably an (unrelated) bug.  ;-)

David


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.