Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 42114
Status: resolved
Priority: 0/
Queue: CGI

People
Owner: MARKSTOS [...] cpan.org
Requestors: rrt [...] sc3d.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



Subject: CGI::Pretty should not put line breaks after A elements
Download (untitled) / with headers
text/plain 358b
CGI::Pretty inserts line breaks after A elements, despite the man page claiming that it does not format them. This effectively inserts a space, breaking formatting. Although the version of CGI.pm on my system is 3.29, which is not the latest, CGI::Pretty is version 1.08, which does seem to be the latest. I got my CGI::Pretty with my Perl, which is 5.10.0.
Download (untitled) / with headers
text/plain 531b
On Sat Jan 03 03:54:14 2009, rrt wrote: Show quoted text
> CGI::Pretty inserts line breaks after A elements, despite the man page > claiming that it does not format them. This effectively inserts a space, > breaking formatting. > > Although the version of CGI.pm on my system is 3.29, which is not the > latest, CGI::Pretty is version 1.08, which does seem to be the latest. I > got my CGI::Pretty with my Perl, which is 5.10.0.
I am unable to confirm this under the current version. Could you post a short script that demonstrates the problem?
Download (untitled) / with headers
text/plain 980b
On Mon Jan 05 10:56:24 2009, LDS wrote: Show quoted text
> I am unable to confirm this under the current version. Could you post > a short script that demonstrates the problem?
Sure. The following script: #! /usr/bin/perl use CGI qw/:standard/; use CGI::Pretty; print header . start_html("hello_word"), "some text" . a({-href => "http://www.example.com/"}, "example link") . "some more text", end_html; produces the following output for me: Content-Type: text/html; charset=ISO-8859-1 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" lang="en-US" xml:lang="en-US"> <head> <title>hello_word</title> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" /> </head> <body> some text<a href="http://www.example.com/">example link</a> some more text </body> </html> Note the line break after </a>, which introduces a space when rendered.
Download (untitled) / with headers
text/plain 1.2k
On Mon Jan 05 14:35:14 2009, rrt wrote: Show quoted text
> On Mon Jan 05 10:56:24 2009, LDS wrote: >
> > I am unable to confirm this under the current version. Could you post > > a short script that demonstrates the problem?
> > Sure. The following script: > > #! /usr/bin/perl > > use CGI qw/:standard/; > use CGI::Pretty; > > print header . start_html("hello_word"), "some text" . a({-href => > "http://www.example.com/"}, "example link") . "some more text", end_html; > > produces the following output for me: > > Content-Type: text/html; charset=ISO-8859-1 > > <!DOCTYPE html > PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" > "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> > <html xmlns="http://www.w3.org/1999/xhtml" lang="en-US"
xml:lang="en-US"> Show quoted text
> <head> > <title>hello_word</title> > <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" /> > </head> > <body> > some text<a href="http://www.example.com/">example link</a> > some more text > </body> > </html> > > Note the line break after </a>, which introduces a space when rendered.
I'm confirmed that this demonstrates the issue with CGI.pm 3.43. To proceed, we'll need the script translated itno an automated test which confirms the issue, and then a patch to resolve it. Mark
Download (untitled) / with headers
text/plain 1.2k
Show quoted text
> > Note the line break after </a>, which introduces a space when rendered.
According to the tests #4 and #8 in t/pretty.t a linebreak after an <a> element is expected. Should those tests be changed? The block of code that generates the linebreak can be found on lines 116-119 in CGI::Pretty.pm version 3.44 (pasted and formatted below): if ( exists \$ASIS{ "\L$tagname\E" } ) { \@result = map { "\$tag\$_\$untag\$CGI::Pretty::LINEBREAK" } \@args; } Removing $CGI::Pretty::LINEBREAK from that statement causes test #12 in t/pretty.t to fail (relevant code snippet pasted below): not ok 12 - nested as-is array-reference # Failed test (t/pretty.t at line 98) # got: '<table> <tr> <td><table> <tr> <td>hi</td><td>there</td><td>frog</td> </tr> </table></td> </tr> </table> ' # expected: '<table> <tr> <td><table> <tr> <td>hi</td> <td>there</td> <td>frog</td> </tr> </table></td> </tr> </table> ' What should be done? 1) Should the man page / documentation be clarified that "not formatting" <a> really means that there is a linebreak after them? 2) Should we remove the offending linebreak from CGI::Pretty.pm and have the <td>'s all on one line? 3) Should we make an exception for <a>'s so that no linebreak is added after them?
Download (untitled) / with headers
text/plain 799b
Show quoted text
> 1) Should the man page / documentation be > clarified that "not formatting" <a> really means that there is a > linebreak after them?
I decided to leave it vague for now and continue to say "unformatted". Show quoted text
> 2) Should we remove the offending linebreak from CGI::Pretty.pm and
have the <td>'s all on one line? I think so. The docs say that <td> is one of the tags we don't format. 3) Should we make Show quoted text
> an exception for <a>'s so that no linebreak is added after them?
I think it's reasonable to skip the linebreak for everything in the AS_IS array. With your help, I've now created a patch for this, with credit to you in the Changes file and pushed it in my public github repo. You can see what you think and possibly refine it further. I'm marking this as "patched" for now. Mark
Subject: Thanks, released
Download (untitled) / with headers
text/plain 160b
The patch for this ticket has now been released in CGI.pm 3.47, and this ticket is considered resolved. Thanks again for you help to improve CGI.pm! Mark
From: rrt [...] sc3d.org
Download (untitled) / with headers
text/plain 453b
On Wed Sep 09 22:07:22 2009, MARKSTOS wrote: Show quoted text
> The patch for this ticket has now been released in CGI.pm 3.47, and
this Show quoted text
> ticket is considered resolved.
This is slightly misleading, as the version of CGI::Pretty in which the bug is fixed is smaller, at most 3.46. It would be most helpful if you could update the bug with the version of CGI::Pretty in which this bug was fixed. This is needed for programs which want to "use" the correct version.
Download (untitled) / with headers
text/plain 756b
On Thu Feb 17 04:31:02 2011, rrt wrote: Show quoted text
> On Wed Sep 09 22:07:22 2009, MARKSTOS wrote:
> > The patch for this ticket has now been released in CGI.pm 3.47, and
> this
> > ticket is considered resolved.
> > This is slightly misleading, as the version of CGI::Pretty in which
the Show quoted text
> bug is fixed is smaller, at most 3.46. It would be most helpful if you > could update the bug with the version of CGI::Pretty in which this bug > was fixed. This is needed for programs which want to "use" the correct > version.
It sounds like you are suggesting that the ticket be updated to document that this was fixed in 3.46, not 3.47. In that case, you've just done that. If you'd like to further research the compatibility of this change, you are welcome to.
From: rrt [...] sc3d.org
Download (untitled) / with headers
text/plain 921b
On Thu Feb 17 07:42:12 2011, MARKSTOS wrote: Show quoted text
> On Thu Feb 17 04:31:02 2011, rrt wrote:
> > On Wed Sep 09 22:07:22 2009, MARKSTOS wrote:
> > > The patch for this ticket has now been released in CGI.pm 3.47,
and Show quoted text
> > this
> > > ticket is considered resolved.
> > > > This is slightly misleading, as the version of CGI::Pretty in which
> the
> > bug is fixed is smaller, at most 3.46. It would be most helpful if
you Show quoted text
> > could update the bug with the version of CGI::Pretty in which this
bug Show quoted text
> > was fixed. This is needed for programs which want to "use" the
correct Show quoted text
> > version.
> > It sounds like you are suggesting that the ticket be updated to
document Show quoted text
> that this was fixed in 3.46, not 3.47.
That is not correct. As you can see from the thread, the bug was fixed in CGI.pm version 3.47. What was unclear is to which version of CGI::Pretty that corresponds. I have now checked: it is CGI::Pretty 3.46.
Download (untitled) / with headers
text/plain 381b
Show quoted text
> That is not correct. As you can see from the thread, the bug was fixed > in CGI.pm version 3.47. What was unclear is to which version of > CGI::Pretty that corresponds. I have now checked: it is CGI::Pretty > 3.46.
Given that you've documented here the detail you seem to be looking for, is there some change you are asking to be made in the CGI.pm distribution? Mark
From: rrt [...] sc3d.org
Download (untitled) / with headers
text/plain 443b
On Thu Feb 17 09:19:06 2011, MARKSTOS wrote: Show quoted text
>
> > That is not correct. As you can see from the thread, the bug was
fixed Show quoted text
> > in CGI.pm version 3.47. What was unclear is to which version of > > CGI::Pretty that corresponds. I have now checked: it is CGI::Pretty > > 3.46.
> > Given that you've documented here the detail you seem to be looking
for, is Show quoted text
> there some change you are asking to be made in the CGI.pm
distribution? No.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.