Skip Menu |
 

This queue is for tickets about the activitymail CPAN distribution.

Report information
The Basics
Id: 4207
Status: resolved
Priority: 0/
Queue: activitymail

People
Owner: Nobody in particular
Requestors: yourgod [...] users.sourceforge.net
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 1.15
Fixed in: 1.16



Subject: Diffed ViewCVS links not practical on SourceForge
Download (untitled) / with headers
text/plain 640b
The problem is that the ViewCVS link is pointing to a server that is a day behind the commit you just made, so the links in the emails are not valid yet. To "fix" this I just added " if $opt_V;" to the end of line 639 so they don't show up without the version numbers being displayed (I don't use this option), but you may want to add another option for this. Some context code (because I don't know how to do a proper diff without a CVS checkout :p): if ($type eq 'mod') { $url .= ".diff?r1=$old&r2=$new" if $opt_V; $nm .= " (r$old -> r$new)" if $opt_V; } elsif ($type eq 'add') {
Date: Fri, 24 Oct 2003 16:23:58 -0700
Subject: Re: [cpan #4207] Diffed ViewCVS links not practical on SourceForge
From: David Wheeler <david [...] kineticode.com>
To: bug-activitymail [...] rt.cpan.org
RT-Send-Cc:
Download (untitled) / with headers
text/plain 858b
On Friday, October 24, 2003, at 02:05 PM, Guest via RT wrote: Show quoted text
> Some context code (because I don't know how to do a proper diff > without a CVS checkout :p):
It's on CSVHome, FWIW. http://activitymail.cvshome.org/servlets/ProjectSource Show quoted text
> if ($type eq 'mod') { > $url .= ".diff?r1=$old&r2=$new" if $opt_V; > $nm .= " (r$old -> r$new)" if $opt_V; > } elsif ($type eq 'add') {
Good idea. I've added this in. Send me your name and I'll give you credit in Changes. Regards, David -- David Wheeler AIM: dwTheory david@kineticode.com ICQ: 15726394 http://www.kineticode.com/ Yahoo!: dew7e Jabber: Theory@jabber.org Kineticode. Setting knowledge in motion.[sm]


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.