Skip Menu |
 

This queue is for tickets about the SOAP-WSDL CPAN distribution.

Report information
The Basics
Id: 42049
Status: resolved
Priority: 0/
Queue: SOAP-WSDL

People
Owner: Nobody in particular
Requestors: adam.prime [...] utoronto.ca
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.00.06
Fixed in: (no value)



Subject: [PATCH] SOAP::WSDL uses default User-Agent
Download (untitled) / with headers
text/plain 417b
SOAP::WSDL currently uses a non-customizable default lwp user-agent of the format libwww-perl/xxxxx. The attached patch changes it to instead use qq[SOAP::WSDL $VERSION], for both WSDL retrieval in wsdl2perl.pl, and more importantly for requests from a SOAP::WSDL based client. I'd also encourage you to make the user-agent customizable, on top of having this as a default. The attached patch is against SVN trunk.
Subject: soap-wsdl.patch
Download soap-wsdl.patch
text/x-diff 818b
Index: lib/SOAP/WSDL.pm =================================================================== --- lib/SOAP/WSDL.pm (revision 759) +++ lib/SOAP/WSDL.pm (working copy) @@ -125,6 +125,7 @@ ? (keep_alive => 1) : () ); + $lwp->agent(qq[SOAP::WSDL $VERSION]); my $response = $lwp->get( $wsdl_of{ $ident } ); croak $response->message() if ($response->code != 200); Index: lib/SOAP/WSDL/Transport/HTTP.pm =================================================================== --- lib/SOAP/WSDL/Transport/HTTP.pm (revision 759) +++ lib/SOAP/WSDL/Transport/HTTP.pm (working copy) @@ -16,6 +16,10 @@ } } +sub _agent { + return qq[SOAP::WSDL $VERSION]; +} + sub send_receive { my ($self, %parameters) = @_; my ($envelope, $soap_action, $endpoint, $encoding, $content_type) =
Subject: Re: [rt.cpan.org #42049] [PATCH] SOAP::WSDL uses default User-Agent
Date: Thu, 29 Jan 2009 08:51:56 +0100
To: bug-SOAP-WSDL [...] rt.cpan.org
From: Martin Kutter <martin.kutter [...] fen-net.de>
Download (untitled) / with headers
text/plain 946b
Hi Adam, applied in SVN in rev771 Thanks, Martin Am Dienstag, den 30.12.2008, 17:54 -0500 schrieb Adam Prime via RT: Show quoted text
> Tue Dec 30 17:54:58 2008: Request 42049 was acted upon. > Transaction: Ticket created by APRIME > Queue: SOAP-WSDL > Subject: [PATCH] SOAP::WSDL uses default User-Agent > Broken in: 2.00.06 > Severity: Important > Owner: Nobody > Requestors: adam.prime@utoronto.ca > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=42049 > > > > SOAP::WSDL currently uses a non-customizable default lwp user-agent of > the format libwww-perl/xxxxx. The attached patch changes it to instead > use qq[SOAP::WSDL $VERSION], for both WSDL retrieval in wsdl2perl.pl, > and more importantly for requests from a SOAP::WSDL based client. > > I'd also encourage you to make the user-agent customizable, on top of > having this as a default. > > The attached patch is against SVN trunk.
Fixed in 2.00.07


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.