Skip Menu |
 
Update: The rt.cpan.org bug tracker service is no longer shutting down.

This queue is for tickets about the Spreadsheet-XLSX CPAN distribution.

Report information
The Basics
Id: 41789
Status: resolved
Priority: 0/
Queue: Spreadsheet-XLSX

People
Owner: Nobody in particular
Requestors: gregoa [...] debian.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Warnings in test suite
Date: Wed, 17 Dec 2008 18:05:06 +0100
To: bug-Spreadsheet-XLSX [...] rt.cpan.org
From: gregor herrmann <gregoa [...] debian.org>
Download (untitled) / with headers
text/plain 1.1k
Hi Dmitry, the test suite of Spreadsheet-XLSX throws a lot of "Use of uninitialized value ..." warnings in lib/Spreadsheet/XLSX.pm line 63 if $formatCode or $default don't exist (because of a missing $1, if I understand the code correctly). The following patch gets rid of the warning, although I'm not sure if it changes anything as a side effect: --- a/lib/Spreadsheet/XLSX.pm +++ b/lib/Spreadsheet/XLSX.pm @@ -59,7 +59,7 @@ foreach my $t1 (@styles){ $member_styles -> contents =~ /numFmtId="$t1" formatCode="([^"]*)/; - my $formatCode=$1; + my $formatCode=$1 || ''; if ($formatCode eq $default || not($formatCode)){ if ($t1 == 9 || $t1==10){ $formatCode="0.00000%";} elsif ($t1 == 14){ $formatCode="m-d-yy";} @@ -68,7 +68,7 @@ } } $style_info{$t1} = $formatCode; - $default=$1; + $default=$1 || ''; } } Please consider looking into this issue. Cheers, gregor (Debian Perl Group) -- .''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/ `- NP: Queen: Let Me Entertain You
Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Subject: Re: Warnings in test suite
Download (untitled) / with headers
text/plain 152b
Hello Gregor, Thank you for the patch, the corrected release is out. But... I didn't see that warning messages. May be you ran some additional tests?
Subject: Re: [rt.cpan.org #41789] Re: Warnings in test suite
Date: Thu, 18 Dec 2008 20:55:05 +0100
To: Dmitry Ovsyanko via RT <bug-Spreadsheet-XLSX [...] rt.cpan.org>
From: gregor herrmann <gregoa [...] debian.org>
Download (untitled) / with headers
text/plain 667b
On Thu, 18 Dec 2008 01:53:52 -0500, Dmitry Ovsyanko via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=41789 > > Thank you for the patch, the corrected release is out.
Thanks for the quick fix! Show quoted text
> But... I didn't see that warning messages. May be you ran some > additional tests?
No, this was just a usual "make test" during building the package for Debian. Cheers, gregor -- .''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/ `- NP: Tom Waits: Diamonds And Gold
Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Closing ticket for previously fixed issue.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.