Skip Menu |
 

This queue is for tickets about the Test-Harness CPAN distribution.

Report information
The Basics
Id: 41664
Status: resolved
Priority: 0/
Queue: Test-Harness

People
Owner: Nobody in particular
Requestors: paul.a.liebert [...] hp.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 3.14
Fixed in: (no value)



Subject: App::Prove problem with .proverc when requesting --exec ''
Download (untitled) / with headers
text/plain 1.1k
App::Prove has trouble recognizing empty string arguments in .proverc. This is problematic for --exec '', which works fine from the command line, but will not function from .proverc Lines 147,148 in App::Prove.pm Version 3.14 are, I beleive, the source of the problem: 147 push @{ $self->{rc_opts} }, grep $_ && $_ !~ /^#/, 148 $line =~ m{ ' ([^']*) ' | " ([^"]*) " | (\#.*) | (\S*) }xg; The following was found to work to my satisfaction. Note that two changes are required, testing for defined on $_, not just truth, and changing \S* to \S+ in the fourth capture. push @{ $self->{rc_opts} }, grep{ defined and not /^#/ } $line =~ m{ ' ([^']*) ' | " ([^"]*) " | (\#.*) | (\S+) }xg; This is perl, v5.10.0 built for i686-linux To reproduce from Linux:bash: 1) mkdir abc 2) cd abc 3) mkdir t 4) cd t 5) cat > 01.t <<EOF #!/bin/bash echo 1..1 echo ok 1 EOF 6) chmod +x 01.t 7) cd .. 8) prove --exec '' t/01......ok All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.00 usr + 0.00 sys = 0.00 CPU) Result: PASS 9) echo "--exec ''" > .proverc 10) prove Option exec requires an argument Unable to continue at /usr/bin/prove line 10
Download (untitled) / with headers
text/plain 1.3k
On Fri Dec 12 13:56:42 2008, paauull wrote: Show quoted text
> App::Prove has trouble recognizing empty string arguments in .proverc. > This is problematic for --exec '', which works fine from the command > line, but will not function from .proverc > > Lines 147,148 in App::Prove.pm Version 3.14 are, I beleive, the source > of the problem: > > 147 push @{ $self->{rc_opts} }, grep $_ && $_ !~ /^#/, > 148 $line =~ m{ ' ([^']*) ' | " ([^"]*) " | (\#.*) | (\S*) }xg; > > The following was found to work to my satisfaction. Note that two > changes are required, testing for defined on $_, not just truth, and > changing \S* to \S+ in the fourth capture. > > push @{ $self->{rc_opts} }, > grep{ defined and not /^#/ } > $line =~ m{ ' ([^']*) ' | " ([^"]*) " | (\#.*) | (\S+) }xg; > > This is perl, v5.10.0 built for i686-linux > > To reproduce from Linux:bash: > 1) mkdir abc > 2) cd abc > 3) mkdir t > 4) cd t > 5) cat > 01.t <<EOF > #!/bin/bash > echo 1..1 > echo ok 1 > EOF > 6) chmod +x 01.t > 7) cd .. > 8) prove --exec '' > t/01......ok > All tests successful. > Files=1, Tests=1, 0 wallclock secs ( 0.00 usr + 0.00 sys = 0.00 CPU) > Result: PASS > 9) echo "--exec ''" > .proverc > 10) prove > Option exec requires an argument > Unable to continue at /usr/bin/prove line 10
Fixed in r1284, thanks :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.