Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-WWW-Mechanize CPAN distribution.

Report information
The Basics
Id: 41282
Status: resolved
Priority: 0/
Queue: Test-WWW-Mechanize

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.22
Fixed in: (no value)



Subject: libwww release breaks tests
Download (untitled) / with headers
text/plain 261b
The libwww-5.821 release seems to have broken your test suite. I just verified this with maint-5.8@34899: when I downgrade to 5.920 tests pass, with 5.821 they fail. Detais in your mailbox from cpantesters. Or if you need further details, please ask. Thanks,
Download (untitled) / with headers
text/plain 681b
On Fri Nov 28 00:01:35 2008, ANDK wrote: Show quoted text
> The libwww-5.821 release seems to have broken your test suite. I just > verified this with maint-5.8@34899: when I downgrade to 5.920 tests > pass, with 5.821 they fail. > > Detais in your mailbox from cpantesters. Or if you need further details, > please ask. > > Thanks,
I think this is the same problem I'm seeing on my linux laptop. I traced the error down to LWP::UserAgent, which is expecting to find a valid URI in the HTTP_PROXY environment variable. The tests are setting the $ENV{http_proxy} value to '', but it should simply be deleted. The attached patch makes this change in all of the tests, and now the tests pass.
Download http_proxy.patch
text/x-diff 4.7k
diff --git a/t/content_contains.t b/t/content_contains.t index 82894b5..932bc2d 100644 --- a/t/content_contains.t +++ b/t/content_contains.t @@ -7,7 +7,7 @@ use Test::Builder::Tester; use URI::file; use constant PORT => 13432; -$ENV{http_proxy} = ''; # All our tests are running on localhost +delete $ENV{http_proxy}; # All our tests are running on localhost BEGIN { use_ok( 'Test::WWW::Mechanize' ); diff --git a/t/content_lacks.t b/t/content_lacks.t index de1fe58..68e5a22 100644 --- a/t/content_lacks.t +++ b/t/content_lacks.t @@ -7,7 +7,7 @@ use Test::Builder::Tester; use URI::file; use constant PORT => 13432; -$ENV{http_proxy} = ''; # All our tests are running on localhost +delete $ENV{http_proxy}; # All our tests are running on localhost BEGIN { use_ok( 'Test::WWW::Mechanize' ); diff --git a/t/follow_link_ok.t b/t/follow_link_ok.t index bad64e5..cbc015d 100644 --- a/t/follow_link_ok.t +++ b/t/follow_link_ok.t @@ -7,7 +7,7 @@ use Test::Builder::Tester; use URI::file; use constant PORT => 13432; -$ENV{http_proxy} = ''; # All our tests are running on localhost +delete $ENV{http_proxy}; # All our tests are running on localhost BEGIN { use_ok( 'Test::WWW::Mechanize' ); diff --git a/t/followable_links.t b/t/followable_links.t index 62fa135..a304b11 100644 --- a/t/followable_links.t +++ b/t/followable_links.t @@ -9,7 +9,7 @@ use constant PORT => 13432; my $base = 'http://localhost:'.PORT; -$ENV{http_proxy} = ''; # All our tests are running on localhost +delete $ENV{http_proxy}; # All our tests are running on localhost BEGIN { use_ok( 'Test::WWW::Mechanize' ); diff --git a/t/get_ok.t b/t/get_ok.t index f489365..8b848a4 100644 --- a/t/get_ok.t +++ b/t/get_ok.t @@ -16,7 +16,7 @@ BEGIN { } BEGIN { - $ENV{http_proxy} = ''; # All our tests are running on localhost + delete $ENV{http_proxy}; # All our tests are running on localhost plan tests => 12; use_ok( 'Test::WWW::Mechanize' ); } diff --git a/t/has_tag.t b/t/has_tag.t index 8a1eaf0..836f4f7 100644 --- a/t/has_tag.t +++ b/t/has_tag.t @@ -8,7 +8,7 @@ use URI::file; use constant PORT => 13432; -$ENV{http_proxy} = ''; # All our tests are running on localhost +delete $ENV{http_proxy}; # All our tests are running on localhost BEGIN { use_ok( 'Test::WWW::Mechanize' ); diff --git a/t/head_ok.t b/t/head_ok.t index 86cdc7d..99a167d 100644 --- a/t/head_ok.t +++ b/t/head_ok.t @@ -16,7 +16,7 @@ BEGIN { } BEGIN { - $ENV{http_proxy} = ''; # All our tests are running on localhost + delete $ENV{http_proxy}; # All our tests are running on localhost plan tests => 12; use_ok( 'Test::WWW::Mechanize' ); } diff --git a/t/link_content.t b/t/link_content.t index fb1ceaf..bc58c85 100644 --- a/t/link_content.t +++ b/t/link_content.t @@ -8,7 +8,7 @@ use URI::file; use constant PORT => 13432; -$ENV{http_proxy} = ''; # All our tests are running on localhost +delete $ENV{http_proxy}; # All our tests are running on localhost BEGIN { use_ok( 'Test::WWW::Mechanize' ); diff --git a/t/link_status.t b/t/link_status.t index dc3041c..f0579f8 100644 --- a/t/link_status.t +++ b/t/link_status.t @@ -8,7 +8,7 @@ use URI::file; use constant PORT => 13432; -$ENV{http_proxy} = ''; # All our tests are running on localhost +delete $ENV{http_proxy}; # All our tests are running on localhost BEGIN { use_ok( 'Test::WWW::Mechanize' ); diff --git a/t/links_ok.t b/t/links_ok.t index d095430..aae7c00 100644 --- a/t/links_ok.t +++ b/t/links_ok.t @@ -8,7 +8,7 @@ use URI::file; use constant PORT => 13432; -$ENV{http_proxy} = ''; # All our tests are running on localhost +delete $ENV{http_proxy}; # All our tests are running on localhost BEGIN { use_ok( 'Test::WWW::Mechanize' ); diff --git a/t/page_links_content.t b/t/page_links_content.t index 326f9be..7412067 100644 --- a/t/page_links_content.t +++ b/t/page_links_content.t @@ -8,7 +8,7 @@ use URI::file; use constant PORT => 13432; -$ENV{http_proxy} = ''; # All our tests are running on localhost +delete $ENV{http_proxy}; # All our tests are running on localhost BEGIN { use_ok( 'Test::WWW::Mechanize' ); diff --git a/t/page_links_ok.t b/t/page_links_ok.t index 8493457..f1999f2 100644 --- a/t/page_links_ok.t +++ b/t/page_links_ok.t @@ -8,7 +8,7 @@ use URI::file; use constant PORT => 13432; -$ENV{http_proxy} = ''; # All our tests are running on localhost +delete $ENV{http_proxy}; # All our tests are running on localhost BEGIN { use_ok( 'Test::WWW::Mechanize' ); diff --git a/t/put_ok.t b/t/put_ok.t index ff6b5c8..3dcdea7 100644 --- a/t/put_ok.t +++ b/t/put_ok.t @@ -16,7 +16,7 @@ BEGIN { } BEGIN { - $ENV{http_proxy} = ''; # All our tests are running on localhost + delete $ENV{http_proxy}; # All our tests are running on localhost plan tests => 12; use_ok( 'Test::WWW::Mechanize' ); }
This has already been handled in the developer release already on CPAN. Thanks, xoxo, Andy


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.