This queue is for tickets about the XML-LibXSLT CPAN distribution.

Report information
The Basics
Id:
40696
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
admiral.grinder [...] gmail.com
Cc:
AdminCc:

BugTracker
Severity:
Important
Broken in:
  • 1.62
  • 1.63
  • 1.66
  • 1.67
Fixed in:
(no value)



Subject: Does not build on Win32
Currently XML::LibXSLT doesn't build on MSWin32 due to differences in the library names between Linux and Windows. After modifing the Makefile.pl to use the correct lib names for the platform, there is a issue with a filename conflict between the xs dll and the lib dll. Here is a patch that tries to address it this issue in 1.66 on Perl 5.8.8. It was originally written (not by me) for v1.62 but does work for it (may have to patch by hand). It currently doesn't work on Perl 5.10 due to a bug in the DynaLoader (rumor has it he fix will be in 5.10.1), however. May want to test it some more though.
Subject: XML-LibXSLT-1.66-win32build.diff
diff -uNr XML-LibXSLT-1.66.orig/LibXSLT.pm XML-LibXSLT-1.66/LibXSLT.pm --- XML-LibXSLT-1.66.orig/LibXSLT.pm 2008-01-29 16:03:05.000000000 -0500 +++ XML-LibXSLT-1.66/LibXSLT.pm 2008-11-05 16:28:14.326138600 -0500 @@ -21,6 +21,11 @@ @ISA = qw(DynaLoader); +# For Windows, change the file extension of the dll we are looking +# for to avoid picking up the real lib LibXSLT. +our $is_Win32 = ($^O =~ /Win32/); +local $DynaLoader::dl_dlext = 'xs.dll' if $is_Win32; + bootstrap XML::LibXSLT $VERSION; # the following magic lets XML::LibXSLT internals know diff -uNr XML-LibXSLT-1.66.orig/Makefile.PL XML-LibXSLT-1.66/Makefile.PL --- XML-LibXSLT-1.66.orig/Makefile.PL 2008-01-29 16:03:05.000000000 -0500 +++ XML-LibXSLT-1.66/Makefile.PL 2008-11-05 16:32:03.547822600 -0500 @@ -62,11 +62,17 @@ } } -if ($config{LIBS} !~ /\-lxslt/) { - $config{LIBS} .= ' -lxslt -lxml2 -lz -lm'; +# If building for Windows, adjust the lib names +my $libxslt_name = $is_Win32 ? 'libxslt' : 'xslt'; + +if ($config{LIBS} !~ /\-l$libxslt_name/) { + my $libxml2_name = $is_Win32 ? 'libxml2' : 'xml2'; + my $libzlib_name = $is_Win32 ? 'zlib' : 'z'; + my $libmath_option = $is_Win32 ? '' : '-lm'; + $config{LIBS} .= " -l$libxslt_name -l$libxml2_name -l$libzlib_name $libmath_option"; } -if (!have_library("xslt")) { +if (!have_library("$libxslt_name")) { print STDERR <<DEATH; libxslt not found Try setting LIBS and INC values on the command line @@ -110,6 +116,12 @@ print "INC: $config{INC}\n"; } +if ( $^O =~ m/Win32/ ) { + # avoid possible shared library name conflict + # maybe the same is reasonable for other platforms? + $config{DLEXT} = 'xs.dll'; +} + WriteMakefile( 'NAME' => 'XML::LibXSLT', 'VERSION_FROM' => 'LibXSLT.pm', # finds $VERSION @@ -284,9 +296,9 @@ use Conftest; \$loaded++; EOT close($cfile); - xsystem("$^X Makefile.PL " . join(' ', map { "'$_=$config{$_}'" } keys %config)); + xsystem("$^X Makefile.PL INC=\"$config{INC}\" LIBS=\"$config{LIBS}\""); my $file = $config{MAKEAPERL} ? "-f Makefile.aperl FIRST_MAKEFILE=Makefile.aperl" : ""; - xsystem("$Config{make} $file test 'OTHERLDFLAGS=$opt'"); + xsystem("$Config{make} $file"); } sub try_link {
This issue was addressed in the SVN by changing the name of the xs dll (should work for perl 5.8.x and presumably for perl >= 5.10.1, perl 5.10 has a know bug in this respect). See https://rt.cpan.org/Ticket/Display.html?id=48247 -- Petr Dne st 05.lis.2008 17:03:29, admiral.grinder@gmail.com napsal(a):
Show quoted text
> Currently XML::LibXSLT doesn't build on MSWin32 due to differences in > the library names between Linux and Windows. After modifing the > Makefile.pl to use the correct lib names for the platform, there is a > issue with a filename conflict between the xs dll and the lib dll. > > Here is a patch that tries to address it this issue in 1.66 on Perl > 5.8.8. It was originally written (not by me) for v1.62 but does work > for it (may have to patch by hand). It currently doesn't work on Perl > 5.10 due to a bug in the DynaLoader (rumor has it he fix will be in > 5.10.1), however. May want to test it some more though.


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.