Skip Menu |
 

This queue is for tickets about the Catalyst-Plugin-I18N-DBIC CPAN distribution.

Report information
The Basics
Id: 40150
Status: new
Priority: 0/
Queue: Catalyst-Plugin-I18N-DBIC

People
Owner: Nobody in particular
Requestors: mst [...] shadowcat.co.uk
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Couple of obvious mistakes
Date: Sat, 18 Oct 2008 14:19:11 +0100
To: bugs-Catalyst-Plugin-I18N-DBIC [...] rt.cpan.org
From: Matt S Trout <mst [...] shadowcat.co.uk>
An empty @path will lead to bad SQL - you should probably leave the keys out of the $where in that case. The eval is horribly and will be nastily slow - you want { # scope so no strict doesn't escape the block no strict 'refs'; ${"${class}::I18N::${lang}::Lexicon"}{$message} = $value; } Also, because all you do is populate the %Lexicon, the main I18N plugin has no idea that the languages you're populating exists, so currently I18N::DBIC only works if the language -also- has a MyApp/I18N/$lang.pm or a .po file for the language. This should be documented, and ::DBIC should also try and provide a way to automatically register them, but I'm not familiar enough with the code involved to be able to suggest how. -- Matt S Trout Need help with your Catalyst or DBIx::Class project? Technical Director http://www.shadowcat.co.uk/catalyst/ Shadowcat Systems Ltd. Want a managed development or deployment platform? http://chainsawblues.vox.com/ http://www.shadowcat.co.uk/servers/


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.