Skip Menu |
 

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 39740
Status: rejected
Priority: 0/
Queue: DBIx-Class

People
Owner: Nobody in particular
Requestors: polettix [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.08010
Fixed in: (no value)

Attachments
0001-Removed-prefetch-in-example-not-needed.patch



Subject: "prefetch" in Example not needed
Download (untitled) / with headers
text/plain 492b
Hi, following a brief discussion in IRC and a quick test, I've come to the belief that "prefetch" in DBIx::Class::Manual::Example is not really needed. I've attached a patch to the documentation module. I think that it could be useful because it really surprised me to see that "prefetch" there in the example, especially after reading the relevant "prefetch" documentation! Cheers, Flavio. PS: The patch has been formatted using "git", but "patch" should grok it with no problem.
Subject: 0001-Removed-prefetch-in-example-not-needed.patch
From 808c73534e321f1b259f7a37d49a79102a15e619 Mon Sep 17 00:00:00 2001 From: Flavio Poletti <flavio@polettix.it> Date: Wed, 1 Oct 2008 14:31:44 +0200 Subject: [PATCH] Removed "prefetch" in example - not needed. 0 2 lib/DBIx/Class/Manual/Example.pod diff --git a/lib/DBIx/Class/Manual/Example.pod b/lib/DBIx/Class/Manual/Example.pod index 2fa0492..884d7fc 100755 --- a/lib/DBIx/Class/Manual/Example.pod +++ b/lib/DBIx/Class/Manual/Example.pod @@ -220,7 +220,6 @@ testdb.pl: }, { join => [qw/ cd /], - prefetch => [qw/ cd /] } ); while (my $track = $rs->next) { @@ -273,7 +272,6 @@ testdb.pl: }, { join => [qw/ artist /], - prefetch => [qw/ artist /] } ); while (my $cd = $rs->next) { -- 1.5.5.4
CC: undisclosed-recipients: ;
Subject: Re: [rt.cpan.org #39740] "prefetch" in Example not needed
Date: Thu, 2 Oct 2008 01:52:26 +0100
To: Flavio Poletti via RT <bug-DBIx-Class [...] rt.cpan.org>
From: Matt S Trout <mst [...] shadowcat.co.uk>
On Wed, Oct 01, 2008 at 08:41:39AM -0400, Flavio Poletti via RT wrote: Show quoted text
> Wed Oct 01 08:41:37 2008: Request 39740 was acted upon. > Transaction: Ticket created by POLETTIX > Queue: DBIx-Class > Subject: "prefetch" in Example not needed > Broken in: 0.08010 > Severity: Unimportant > Owner: Nobody > Requestors: polettix@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=39740 > > > > Hi, > > following a brief discussion in IRC and a quick test, I've come to > the belief that "prefetch" in DBIx::Class::Manual::Example is not really > needed. I've attached a patch to the documentation module.
The DBIx::Class doc team aren't on RT, could you please re-send to the mailing list? -- Matt S Trout Need help with your Catalyst or DBIx::Class project? Technical Director http://www.shadowcat.co.uk/catalyst/ Shadowcat Systems Ltd. Want a managed development or deployment platform? http://chainsawblues.vox.com/ http://www.shadowcat.co.uk/servers/
Doc maintainers not on RT, sending patch to the mailing list.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.