Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 39639
Status: open
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: at [...] altlinux.ru
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: (no value)
Fixed in: (no value)



Subject: fix_shebang_line makes versioned shebang
Date: Sat, 27 Sep 2008 12:13:20 +0000
To: bug-Module-Build [...] rt.cpan.org
From: Alexey Tourbin <at [...] altlinux.ru>
Download (untitled) / with headers
text/plain 1.3k
lib/Module/Build/Base.pm: 2465 sub fix_shebang_line { # Adapted from fixin() in ExtUtils::MM_Unix 1.35 2466 my ($self, @files) = @_; 2467 my $c = ref($self) ? $self->{config} : 'Module::Build::Config'; 2468 2469 my ($does_shbang) = $c->get('sharpbang') =~ /^\s*\#\!/; 2470 for my $file (@files) { 2471 my $FIXIN = IO::File->new($file) or die "Can't process '$file': $!"; 2472 local $/ = "\n"; 2473 chomp(my $line = <$FIXIN>); 2474 next unless $line =~ s/^\s*\#!\s*//; # Not a shbang file. 2475 2476 my ($cmd, $arg) = (split(' ', $line, 2), ''); 2477 next unless $cmd =~ /perl/i; 2478 my $interpreter = $self->{properties}{perl}; 2479 2480 $self->log_verbose("Changing sharpbang in $file to $interpreter"); 2481 my $shb = ''; 2482 $shb .= $c->get('sharpbang')."$interpreter $arg\n" if $does_shbang; Here, $interpreter is e.g. /usr/bin/perl5.8.8, and, unlike ExtUtils::MM_Unix::fixin(), this yields shebang line specific to the installed perl version, which is rather undesired. $ head -1 Module-Build-0.30/blib/script/config_data #!/usr/bin/perl5.8.8 $ Perhaps $Config{startperl} should be used instead. $ perl -le 'print $^X' /usr/bin/perl5.8.8 $ perl -le 'use Config; print $Config{startperl}' #!/usr/bin/perl $
Subject: Re: [rt.cpan.org #39639] fix_shebang_line makes versioned shebang
Date: Sat, 27 Sep 2008 15:32:50 -0400
To: bug-Module-Build [...] rt.cpan.org
From: Michael G Schwern <schwern [...] pobox.com>
Download (untitled) / with headers
text/plain 327b
Alexey Tourbin via RT wrote: Show quoted text
> Here, $interpreter is e.g. /usr/bin/perl5.8.8, and, unlike > ExtUtils::MM_Unix::fixin(), this yields shebang line specific > to the installed perl version, which is rather undesired.
My client, the devil, has instructed me to inquire why is it rather undesired? -- Hating the web since 1994.
Marking it "open" following the new convention that "open" means it's been triaged appropriately.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.