This queue is for tickets about the CPAN-Checksums CPAN distribution.

Report information
The Basics
Id:
38944
Status:
resolved
Priority:
Low/Low

People
Owner:
Nobody in particular
Requestors:
perl [...] galumph.com
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



Subject: Missing binmode on filehandle causes invalid checksums on Windows.
Date: Wed, 03 Sep 2008 07:31:11 -0500
To: bug-CPAN-Checksums@rt.cpan.org
From: Elliot Shank <perl@galumph.com>
Patch is against version 2.00.
--- lib/CPAN/Checksums.pm 2008-05-17 00:15:20.000000000 -0500 +++ lib/CPAN/Checksums.pm.fixed 2008-09-03 07:23:41.000000000 -0500 @@ -219,6 +219,7 @@ my($fh) = new IO::File; my $dig = $module->new(@$constructor_args); $fh->open("$abs\0") or die "Couldn't open $abs: $!"; + $fh->binmode(); $dig->addfile($fh); $fh->close; my $digest = $dig->hexdigest;
Subject: Re: [rt.cpan.org #38944] Missing binmode on filehandle causes invalid checksums on Windows.
Date: Wed, 03 Sep 2008 21:34:07 +0200
To: bug-CPAN-Checksums@rt.cpan.org
From: andreas.koenig.7os6VVqR@franz.ak.mind.de (Andreas J. Koenig)
Show quoted text
>>>>> On Wed, 03 Sep 2008 08:31:39 -0400, "Elliot Shank via RT" <bug-CPAN-Checksums@rt.cpan.org> said:
Show quoted text
> + $fh->binmode();
Well spotted, thanks! New release is on the way to CPAN. -- andreas
This was resolved in revision 2.01, 2008-09-03. Just forgot to resolve, doing now


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.