Skip Menu |
 

This queue is for tickets about the POE-Component-Client-HTTP CPAN distribution.

Report information
The Basics
Id: 38176
Status: resolved
Priority: 0/
Queue: POE-Component-Client-HTTP

People
Owner: Nobody in particular
Requestors: melazyboy [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
0001-fixed-security-issue-with-lib-and-home.patch
0002-fixed-pod-comma-error-and-wrong-var-name.patch



Subject: TWO PATCHES FOR GREAT JUSTICE
two patches one fixes security issue in tests, one patches docs to not suck at life.
Subject: 0002-fixed-pod-comma-error-and-wrong-var-name.patch
From 838438024f08fe4244aaddeaa73d8b7cdc588d14 Mon Sep 17 00:00:00 2001 From: root <root@x60s.(none)> Date: Mon, 4 Aug 2008 16:44:00 -0500 Subject: [PATCH] fixed pod, comma error, and wrong var name :100644 100644 d4b43ae... ea20b0f... M lib/POE/Component/Client/HTTP.pm diff --git a/lib/POE/Component/Client/HTTP.pm b/lib/POE/Component/Client/HTTP.pm index d4b43ae..ea20b0f 100644 --- a/lib/POE/Component/Client/HTTP.pm +++ b/lib/POE/Component/Client/HTTP.pm @@ -975,24 +975,24 @@ POE::Component::Client::HTTP - a HTTP user-agent component use POE qw(Component::Client::HTTP); POE::Component::Client::HTTP->spawn( - Agent => 'SpiffCrawler/0.90', # defaults to something long - Alias => 'ua', # defaults to 'weeble' - From => 'spiffster@perl.org', # defaults to undef (no header) - Protocol => 'HTTP/0.9', # defaults to 'HTTP/1.1' - Timeout => 60, # defaults to 180 seconds - MaxSize => 16384, # defaults to entire response - Streaming => 4096, # defaults to 0 (off) - FollowRedirects => 2 # defaults to 0 (off) - Proxy => "http://localhost:80", # defaults to HTTP_PROXY env. variable - NoProxy => [ "localhost", "127.0.0.1" ], # defs to NO_PROXY env. variable - BindAddr => "12.34.56.78", # defaults to INADDR_ANY + Agent => 'SpiffCrawler/0.90' # defaults to something long + , Alias => 'ua' # defaults to 'weeble' + , From => 'spiffster@perl.org' # defaults to undef (no header) + , Protocol => 'HTTP/0.9' # defaults to 'HTTP/1.1' + , Timeout => 60 # defaults to 180 seconds + , MaxSize => 16384 # defaults to entire response + , Streaming => 4096 # defaults to 0 (off) + , FollowRedirects => 2 # defaults to 0 (off) + , Proxy => "http://localhost:80" # defaults to HTTP_PROXY env. variable + , NoProxy => [ "localhost" "127.0.0.1" ] # defs to NO_PROXY env. variable + , BindAddr => "12.34.56.78" # defaults to INADDR_ANY ); - $kernel->post( - 'ua', # posts to the 'ua' alias - 'request', # posts to ua's 'request' state - 'response', # which of our states will receive the response - $request, # an HTTP::Request object + $poe_kernel->post( + 'ua' # posts to the 'ua' alias + , 'request' # posts to ua's 'request' state + , 'response' # which of our states will receive the response + , $request # an HTTP::Request object ); # This is the sub which is called when the session receives a -- 1.5.3.4.206.g58ba4
Subject: 0001-fixed-security-issue-with-lib-and-home.patch
From 19369deaf710c2ebd8bcacb36c57154ffff18392 Mon Sep 17 00:00:00 2001 From: root <root@x60s.(none)> Date: Mon, 4 Aug 2008 16:30:59 -0500 Subject: [PATCH] fixed security issue with lib and home :100644 100644 7f2dd6b... f33fb67... M t/01_request.t :100644 100644 40b2f68... ca9bf6b... M t/11_cancel.t diff --git a/t/01_request.t b/t/01_request.t index 7f2dd6b..f33fb67 100644 --- a/t/01_request.t +++ b/t/01_request.t @@ -6,7 +6,6 @@ use strict; use HTTP::Request::Common qw(GET POST); -use lib '/home/troc/perl/poe'; sub POE::Kernel::ASSERT_DEFAULT () { 1 } use POE qw(Component::Client::HTTP Component::Client::Keepalive); diff --git a/t/11_cancel.t b/t/11_cancel.t index 40b2f68..ca9bf6b 100644 --- a/t/11_cancel.t +++ b/t/11_cancel.t @@ -6,7 +6,6 @@ use strict; use HTTP::Request::Common qw(GET POST); -use lib '/home/troc/perl/poe'; sub POE::Kernel::ASSERT_DEFAULT () { 1 } use POE qw(Component::Client::HTTP Component::Client::Keepalive); -- 1.5.3.4.206.g58ba4
Patch applied, thanks.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.