Skip Menu |
 

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 37997
Status: resolved
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors: martijn [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.66
Fixed in: (no value)



Subject: case typos in XML::LibXML::SAX::Builder
Download (untitled) / with headers
text/plain 164b
the start_dtd method of XML::LibXML::SAX::Builder uses SystemID and PublicID, while the SAX events generated use SystemId and PublicId.I attached a patch to fix it.
Subject: saxbuilder.diff
Download saxbuilder.diff
text/x-diff 543b
--- /usr/lib/perl5/XML/LibXML/SAX/Builder.pm 2008-01-29 22:01:49.000000000 +0100 +++ Builder.pm 2008-07-28 19:03:17.000000000 +0200 @@ -36,8 +36,8 @@ sub start_dtd { my ($self, $dtd) = @_; if (defined $dtd->{Name} and - (defined $dtd->{SystemID} or defined $dtd->{PublicID})) { - $self->{DOM}->createExternalSubset($dtd->{Name},$dtd->{PublicID},$dtd->{SystemID}); + (defined $dtd->{SystemId} or defined $dtd->{PublicId})) { + $self->{DOM}->createExternalSubset($dtd->{Name},$dtd->{PublicId},$dtd->{SystemId}); } }
thanks, your patch applied to SVN; it will appear in 1.67 soon. -- petr


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.