Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 35697
Status: rejected
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: mst [...] shadowcat.co.uk
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Module::Build::Version can't handle 1_01 style
Date: Wed, 7 May 2008 20:48:24 +0100
To: bugs-Module-Build [...] rt.cpan.org
From: Matt S Trout <mst [...] shadowcat.co.uk>
Download (untitled) / with headers
text/plain 740b
Module::Build::Version->new("1_01"); Error: Invalid version format (alpha without decimal) I'm not sure if that's actually valid, though given 1.01_01 is I don't see why the . is compulsory. However if it isn't valid, a more useful error would be nice. I'd also note that when ModuleInfo's sub _evaluate_version_line produces this error it'd be nice to have it re-thrown with the file name included for quicker debugging. -- Matt S Trout Need help with your Catalyst or DBIx::Class project? Technical Director http://www.shadowcat.co.uk/catalyst/ Shadowcat Systems Ltd. Want a managed development or deployment platform? http://chainsawblues.vox.com/ http://www.shadowcat.co.uk/servers/
CC: John Peacock <john.peacock [...] havurah-software.org>
Subject: Re: [rt.cpan.org #35697] Module::Build::Version can't handle 1_01 style
Date: Wed, 7 May 2008 13:30:46 -0700
To: bug-Module-Build [...] rt.cpan.org
From: Eric Wilhelm <scratchcomputing [...] gmail.com>
Download (untitled) / with headers
text/plain 972b
# from Matt S Trout via RT # on Wednesday 07 May 2008: Show quoted text
>Module::Build::Version->new("1_01"); > >Error: Invalid version format (alpha without decimal) >I'm not sure if that's actually valid, though given 1.01_01 is I don't >see why the . is compulsory.
This is straight out of version.pm -- perhaps you want to report it there and/or discuss it with John Peacock. Show quoted text
> However if it isn't valid, a more useful error would be nice.
I'm not sure if version.pm can be much more informative. I suppose it could include the package name when invoked as VERSION(), but AFAICT the constructor only knows caller(). $ perl -I/tmp -e 'use version; use foo; warn foo->VERSION' Invalid version format (alpha without decimal) at -e line 1. Show quoted text
>I'd also note that when ModuleInfo's sub _evaluate_version_line >produces this error it'd be nice to have it re-thrown with the file >name included for quicker debugging.
That bit would make a fine feature request for M::B. --Eric


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.