Skip Menu |
 

This queue is for tickets about the libwww-perl CPAN distribution.

Report information
The Basics
Id: 35457
Status: resolved
Priority: 0/
Queue: libwww-perl

People
Owner: Nobody in particular
Requestors: ville.skytta [...] iki.fi
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 5.812
Fixed in: (no value)

Attachments


Subject: [PATCH] Spelling fixes
Attached is a bunch of trivial spelling fixes against current git.
Subject: 0002-Spelling-fixes.patch
From 9946e3f257ca20028543bbaed10085f2c64e4565 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ville=20Skytt=C3=A4?= <ville.skytta@iki.fi> Date: Sun, 27 Apr 2008 00:17:42 +0300 Subject: [PATCH] Spelling fixes. --- bin/lwp-download | 2 +- lib/HTTP/Negotiate.pm | 16 ++++++++-------- lib/HTTP/Response.pm | 3 +-- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/bin/lwp-download b/bin/lwp-download index b1e8a16..c36fde1 100755 --- a/bin/lwp-download +++ b/bin/lwp-download @@ -119,7 +119,7 @@ my $res = $ua->request(HTTP::Request->new(GET => $url), # if this fails we try to make something from the URL unless ($file) { - my $req = $res->request; # now always there + my $req = $res->request; # not always there my $rurl = $req ? $req->url : $url; $file = ($rurl->path_segments)[-1]; diff --git a/lib/HTTP/Negotiate.pm b/lib/HTTP/Negotiate.pm index 859d54e..f6f1edf 100644 --- a/lib/HTTP/Negotiate.pm +++ b/lib/HTTP/Negotiate.pm @@ -18,7 +18,7 @@ sub choose ($;$) my(%accept); unless (defined $request) { - # Create a request object from the CGI envirionment variables + # Create a request object from the CGI environment variables $request = new HTTP::Headers; $request->header('Accept', $ENV{HTTP_ACCEPT}) if $ENV{HTTP_ACCEPT}; @@ -105,7 +105,7 @@ sub choose ($;$) } my @Q = (); # This is where we collect the results of the - # quality calcualtions + # quality calculations # Calculate quality for all the variants that are available. for (@$variants) { @@ -126,9 +126,9 @@ sub choose ($;$) # Calculate encoding quality my $qe = 1; - # If the variant has no assignes Content-Encoding, or if no + # If the variant has no assigned Content-Encoding, or if no # Accept-Encoding field is present, then the value assigned - # is "qe=1". If *all* of the variant's content encoddings + # is "qe=1". If *all* of the variant's content encodings # are listed in the Accept-Encoding field, then the value # assigned is "qw=1". If *any* of the variant's content # encodings are not listed in the provided Accept-Encoding @@ -150,7 +150,7 @@ sub choose ($;$) # Calculate charset quality my $qc = 1; - # If the variant's media-type has not charset parameter, + # If the variant's media-type has no charset parameter, # or the variant's charset is US-ASCII, or if no Accept-Charset # field is present, then the value assigned is "qc=1". If the # variant's charset is listed in the Accept-Charset field, @@ -167,7 +167,7 @@ sub choose ($;$) my @lang = ref($lang) ? @$lang : ($lang); # If any of the variant's content languages are listed # in the Accept-Language field, the the value assigned is - # the maximus of the "q" paramet values for thos language + # the largest of the "q" parameter values for those language # tags. my $q = undef; for (@lang) { @@ -319,8 +319,8 @@ HTTP::Negotiate - choose a variant to serve ['var3', 0.3, 'image/gif', undef, undef, undef, 43555], ]; - @prefered = choose($variants, $request_headers); - $the_one = choose($variants); + @preferred = choose($variants, $request_headers); + $the_one = choose($variants); =head1 DESCRIPTION diff --git a/lib/HTTP/Response.pm b/lib/HTTP/Response.pm index 7be9619..f55b7a8 100644 --- a/lib/HTTP/Response.pm +++ b/lib/HTTP/Response.pm @@ -376,8 +376,7 @@ received some redirect responses first. =back -If neither of these sources provide an absolute URI, undef is -returned. +If none of these sources provide an absolute URI, undef is returned. When the LWP protocol modules produce the HTTP::Response object, then any base URI embedded in the document (step 1) will already have -- 1.5.4.3
Applied. Thanks!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.