Skip Menu |
 

This queue is for tickets about the WWW-Dilbert CPAN distribution.

Report information
The Basics
Id: 35402
Status: open
Priority: 0/
Queue: WWW-Dilbert

People
Owner: Nobody in particular
Requestors: davidp [...] preshweb.co.uk
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: Fails to fetch now that Dilbert page has changed
Download (untitled) / with headers
text/plain 131b
Now that the Dilbert website has changed, WWW::Dilbert can no longer find the comic. A patch is attached which resolves it for me.
Subject: Dilbert.pm.patch
Download Dilbert.pm.patch
text/x-diff 638b
--- Dilbert.pm.orig 2008-04-25 09:50:58.000000000 +0100 +++ Dilbert.pm 2008-04-25 09:55:28.000000000 +0100 @@ -98,10 +98,10 @@ my $response = $ua->get('http://www.dilbert.com'); if ($response->is_success) { my $html = $response->content; - if ($html =~ m#<img\s+src="((?:https?://[\w\.:\d\/]+)? - /comics/dilbert/archive/images/dilbert.+?)"#imsx) { + if ($html =~ m{<img \s+ src="( [^"]+ strip.print.gif)"}imsx) { my $url = $1; - $url = "http://www.dilbert.com$1" unless $url =~ /^https?:\/\//i; + $url = "http://www.dilbert.com$1" + unless $url =~ m{^https?://}i; return $url; }
Download (untitled) / with headers
text/plain 106b
If it's easier for you Nicola, I'd be happy to take over maintainership and release a new version for you?
Download (untitled) / with headers
text/plain 189b
Any chance you could find time at some point to apply the patch, or alternatively give me co-maintainer status on this module so I can release a fixed version? I'd greatly appreciate it :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.